From mboxrd@z Thu Jan 1 00:00:00 1970 From: david.vrabel@citrix.com (David Vrabel) Date: Mon, 28 Sep 2015 15:22:40 +0100 Subject: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 In-Reply-To: <56094891.2000409@oracle.com> References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> <560947B6.1030101@citrix.com> <56094891.2000409@oracle.com> Message-ID: <56094D30.7080305@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: >>>> The PCI support for Xen doesn't compile on ARM/ARM64 when >>>> CONFIG_PCI_MMCONFIG=y: >>>> >>>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >>>> directory >>>> #include >>>> >>>> Although, Xen is not currently involved in PCI management for >>>> ARM/ARM64. >>>> There is plan to support it, but it would require some changes in Linux >>>> side. >>>> >>>> For now, introduce a new config options XEN_PCI which will be turned >>>> off >>>> for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? This. >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). Or preferably this. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757500AbbI1OXF (ORCPT ); Mon, 28 Sep 2015 10:23:05 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:44732 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753829AbbI1OXC (ORCPT ); Mon, 28 Sep 2015 10:23:02 -0400 X-IronPort-AV: E=Sophos;i="5.17,602,1437436800"; d="scan'208";a="306557523" Message-ID: <56094D30.7080305@citrix.com> Date: Mon, 28 Sep 2015 15:22:40 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Boris Ostrovsky , Julien Grall , CC: , , , Robert Richter , Subject: Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> <560947B6.1030101@citrix.com> <56094891.2000409@oracle.com> In-Reply-To: <56094891.2000409@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: >>>> The PCI support for Xen doesn't compile on ARM/ARM64 when >>>> CONFIG_PCI_MMCONFIG=y: >>>> >>>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >>>> directory >>>> #include >>>> >>>> Although, Xen is not currently involved in PCI management for >>>> ARM/ARM64. >>>> There is plan to support it, but it would require some changes in Linux >>>> side. >>>> >>>> For now, introduce a new config options XEN_PCI which will be turned >>>> off >>>> for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? This. >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). Or preferably this. David