From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH 1/8] xen/arm: gic: Make clear the GIC node
 is passed to make_hwdom_dt_node
Date: Mon, 28 Sep 2015 15:49:16 +0100
Message-ID: <5609536C.5090102@citrix.com>
References: <1442944062-4324-1-git-send-email-julien.grall@citrix.com>
	<1442944062-4324-2-git-send-email-julien.grall@citrix.com>
	<1443196098.25250.174.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7067c2ced=julien.grall@citrix.com>)
	id 1ZgZlj-00017r-15
	for xen-devel@lists.xenproject.org; Mon, 28 Sep 2015 14:51:07 +0000
In-Reply-To: <1443196098.25250.174.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 25/09/15 16:48, Ian Campbell wrote:
> On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote:
> 
> "Make it clear..." in the subject.
> 
>> The callback make_hwdom_dt_node already have the gic node in parameter.
> 
> "...already has the..." or "...already takes the..."
> 
>> Rather than using a weird mix between "dt_interrupt_controller" (aliased
>> to "gic") and "node", rename the callback parameter "node" to "gic".
> 
> "... and remove local gic definitions in terms of the global
> dt_interrupt_controller".
> 
> Also given the hunk below I'd recommend adding:
> "Add an assert to gic_make_hwdom_dt_node to check that the gic really is
> the global dt_interrupt_controller"

Your suggestions looks good. Although, I replaced gic by GIC because
it's an acronym.

>> @@ -702,10 +702,12 @@ void __cpuinit init_maintenance_interrupt(void)
>>  }
>>  
>>  int gic_make_hwdom_dt_node(const struct domain *d,
>> -                           const struct dt_device_node *node,
>> +                           const struct dt_device_node *gic,
>>                             void *fdt)
>>  {
>> -    return gic_hw_ops->make_hwdom_dt_node(d, node, fdt);
>> +    ASSERT(gic == dt_interrupt_controller);
>> +
>> +    return gic_hw_ops->make_hwdom_dt_node(d, gic, fdt);
>>  }
> 
> With those commit message changes:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thank you!


Regards,

-- 
Julien Grall