From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v1 2/8] xen/arm: io: Extend write/read
 handler to pass the register in parameter
Date: Mon, 28 Sep 2015 17:35:48 +0100
Message-ID: <56096C64.9040306@citrix.com>
References: <1443192698-16163-1-git-send-email-julien.grall@citrix.com>
	<1443192698-16163-3-git-send-email-julien.grall@citrix.com>
	<1443198971.25250.205.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7067c2ced=julien.grall@citrix.com>)
	id 1ZgbZS-0002ML-Sh
	for xen-devel@lists.xenproject.org; Mon, 28 Sep 2015 16:46:34 +0000
In-Reply-To: <1443198971.25250.205.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xenproject.org
Cc: Vijaya.Kumar@caviumnetworks.com, Julien Grall <julien.grall@linaro.org>, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com, vijay.kilari@gmail.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 25/09/15 17:36, Ian Campbell wrote:
> On Fri, 2015-09-25 at 15:51 +0100, Julien Grall wrote:
>> From: Julien Grall <julien.grall@linaro.org>
>>
>> Rather than letting each handler to retrieve the register used by the
>> I/O access, add a new parameter to pass the register in parameter.
>>
>> This will help to implement generic register manipulation on I/O access
>> such as sign-extension and endianess.
>>
>> Read handlers need to modify the value of the register, so a pointer to
>> it is given in argument. Write handlers shouldn't modify the register,
>> therfore only a plain value is given.
> 
> "therefore"
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com.
> 
> Is it the case that read handlers today only update *r on success? 

Yes, each read handler only update the register mentioned in dabt.reg.

> Is that
> a useful thing to mandate and/or enforce?

What do you mean?

Regards,

-- 
Julien Grall