From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCHv4 2/9] null: fix segfault when null_pmd added
 to bonding
Date: Tue, 29 Sep 2015 11:24:26 +0900
Message-ID: <5609F65A.6050208@igel.co.jp>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com
 [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 261C91396
 for <dev@dpdk.org>; Tue, 29 Sep 2015 04:24:29 +0200 (CEST)
Received: by padhy16 with SMTP id hy16so190914244pad.1
 for <dev@dpdk.org>; Mon, 28 Sep 2015 19:24:28 -0700 (PDT)
In-Reply-To: <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/07/16 2:26, Tomasz Kulasek wrote:
> When device is added to the bonding, the link status callback is added to
> the slave's eth_dev->link_intr_cbs list. This list is not initialized for
> null pmd and adding it to the bonding segfaults application.
>
> This patch allocates and sets up required structures.
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/null/rte_eth_null.c |   11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index e244595..a8b3191 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -386,6 +386,7 @@ eth_dev_null_create(const char *name,
>  	const unsigned nb_rx_queues = 1;
>  	const unsigned nb_tx_queues = 1;
>  	struct rte_eth_dev_data *data = NULL;
> +	struct eth_driver *eth_drv = NULL;

Hi Tomasz,

Thanks for extending null pmd features.
Is it possible to use rte_null_pmd here?
Could you please check ring pmd? It may also uses rte_ring_pmd for link
status callback.

Tetsuya