From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933250AbbI2IUz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 04:20:55 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:38435 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932878AbbI2IUp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 04:20:45 -0400
Subject: Re: [tip:perf/core] tools: Add err.h with ERR_PTR PTR_ERR interface
To: Jiri Olsa <jolsa@redhat.com>
References: <1441615087-13886-2-git-send-email-jolsa@kernel.org>
 <tip-01ca9fd41d6f2ad796a6b109b5253e06b6ae6dc7@git.kernel.org>
 <CAHTgTXUTvFfcjRw=PY2eyhGy+jxOoeGSQFB9wtWu7pU3HhNp0Q@mail.gmail.com>
 <CAHTgTXVwdyxWeaV1+JR1mJDU8PC=yqEOdQH34WutF8kyZuj=mg@mail.gmail.com>
 <20150929071410.GA27383@krava.redhat.com>
 <20150929072028.GB27383@krava.redhat.com> <560A4329.7090100@huawei.com>
 <20150929075717.GC27383@krava.redhat.com>
CC: Vinson Lee <vlee@twopensource.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, <raphael.beamonte@gmail.com>,
        <matt@codeblueprint.co.uk>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>,
        <linux-tip-commits@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From: He Kuang <hekuang@huawei.com>
Message-ID: <560A48AB.7040907@huawei.com>
Date: Tue, 29 Sep 2015 16:15:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.0
MIME-Version: 1.0
In-Reply-To: <20150929075717.GC27383@krava.redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.110.54.65]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/9/29 15:57, Jiri Olsa wrote:
> On Tue, Sep 29, 2015 at 03:52:09PM +0800, He Kuang wrote:
>> hi, jirka
>>
>> On 2015/9/29 15:20, Jiri Olsa wrote:
>>> On Tue, Sep 29, 2015 at 09:14:10AM +0200, Jiri Olsa wrote:
>>>
>>> SNIP
>>>
>>>>>> $ gcc --version
>>>>>> gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16)
>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>> This is free software; see the source for copying conditions.  There is NO
>>>>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>>>>>>
>>>>>> Cheers,
>>>>>> Vinson
>>>>>
>>>>> Hi.
>>>>>
>>>>> This build error still occurs with next-20150929.
>>>>
>>>> attached patch should fix it
>>>>
>>>> FYI there's another instance of this bug in parse-events.c in
>>>> Arnaldo's perf/core due to recent fixes, I'll send out fix shortly
>>>
>>> and here it is..
>>>
>>> He Kuang,
>>> this might collide with your recent fixes..
>>>
>>
>> Do I need to send new ones based on your patch below now?
>
> that'd be great.. also please make sure you don't reintroduce it
>

I saw Ingo just accepted ACME's pull request which contains my patches,
then resend may reintroduce or conflict things, I will wait for ACME's
suggestion for my lack of experience in this.

Thank you.

> thanks,
> jirka
>