From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgrOk-0007Nz-Tf for qemu-devel@nongnu.org; Tue, 29 Sep 2015 05:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgrOh-00028w-ED for qemu-devel@nongnu.org; Tue, 29 Sep 2015 05:40:34 -0400 References: <1443090459-9281-1-git-send-email-lvivier@redhat.com> <1443090459-9281-3-git-send-email-lvivier@redhat.com> <20150929051844.GM19428@voom.redhat.com> <560A4DCB.1080109@redhat.com> From: Thomas Huth Message-ID: <560A5C84.4030804@redhat.com> Date: Tue, 29 Sep 2015 11:40:20 +0200 MIME-Version: 1.0 In-Reply-To: <560A4DCB.1080109@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qlg2LJAOkuN3NLMGSE2lS3SdBh0oDULd7" Subject: Re: [Qemu-devel] [PATCH v4 2/2] spapr: generate DT node names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , David Gibson Cc: "Michael S. Tsirkin" , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Qlg2LJAOkuN3NLMGSE2lS3SdBh0oDULd7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29/09/15 10:37, Laurent Vivier wrote: >=20 >=20 > On 29/09/2015 07:18, David Gibson wrote: >> On Thu, Sep 24, 2015 at 12:27:39PM +0200, Laurent Vivier wrote: =2E.. >>> - /* NOTE: this is normally generated by firmware via >>> path/unit name, - * but in our case we must set it manually >>> since it does not get - * processed by OF beforehand - >>> */ - _FDT(fdt_setprop_string(fdt, offset, "name", "pci")); + >>> _FDT(fdt_setprop_string(fdt, offset, "name", + >>> pci_find_device_name((ccode >> 16) & 0xff, + >>> (ccode >> 8) & 0xff, + >>> ccode & 0xff))); >=20 >> Heh. This isn't wrong, but there's a non-obvious wrinkle as to >> why. Generally flattened trees shouldn't require the 'name' >> property (the consumer is supposed to infer that from the node >> name). However, since this may also be used to generate tree >> fragments which get passed through the PAPR dynamic reconfiguration >> interface, and that *does* expect the name property to be passed >> through. >=20 > In fact, this is also the behavior of SLOF. Well, SLOF builds an Open Firmware device tree (not a flattened device tree), thus the "name" property is always required there. Thomas --Qlg2LJAOkuN3NLMGSE2lS3SdBh0oDULd7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWClyJAAoJEC7Z13T+cC21RaYP/3bEVvgL9U1EZ7nseqQBmVKg mDXZ75+AtP/5zlcCy1ZQ6s8Z8KdLlpAr1Dh//Gq99dmMeAW7XhWmY4oic0xPmezB 8sHrNace+2nqlUWNV30KYSW5ce7Q9WhYMAZ9/ObzhhRc4g+fvySRyFGIiIkUJfEG KE/5+TcOpnRBert9i3L3su3aM2YxNsD1JhzOW3KOVBhYBAycM0HAiTxKcHroDdS1 Zhp+aofqhUOy6Kf7nzUrsyO7sj26oYCz2rqLH1rDC4ix+k6/9ZAjiTWAOAkd4QGO R4CTYEYArzB1bYkcwxR+FBmEZh1+u1ckU4ukO9WOn8GkbbSrq9mjDF90t22KOTW2 V7ArUKA099v1dG4QDm7FJK5YvTbTI3KLTFGRg8M3ROeCnfjax0EucfcE3oFC8dgk Q+YwwRLqKiu7QDDGXnXiAcI95B08pFvWoUcZHd41r2mFU0Y2qLgT+Z6W+MdJKgpc XDBHsw4QSz0d6of1nqkKTT9/hYAihY2oa8mrUWzDoKaJuVQcf8oqDyaCxqw7dvsq TpV58tLP6mQm3FnGtdnHQ04CSY5uev42Wp9ZLI2j3hZI7IhVuwXwAxetPRXDojt0 tjauZmQ5sFkBieqszu5Py3jLdpADgtrAud9O2od1+fRQ8wxmn4izaSFUmO9MdGTW n7hdJHKEP9CvSHRj4nSq =oxYf -----END PGP SIGNATURE----- --Qlg2LJAOkuN3NLMGSE2lS3SdBh0oDULd7--