Re: [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd

[Ioan-Adrian Ratiu <adrian.ratiu@ni.com>]

On 28.09.2015 19:07, Khem Raj wrote:
>
>> On Sep 28, 2015, at 4:44 AM, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>
>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>> ---
>> meta-oe/recipes-support/vim/vim_7.4.481.bb | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> index 2ece53b..fcd036b 100644
>> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> @@ -59,6 +59,11 @@ EXTRA_OECONF = " \
>>      STRIP=/bin/true \
>> "
>>
>> +do_compile_append() {
>> +    cd "${S}/xxd"
>> +    make
>
> why not oe_runmake ?

I did some more research and indeed oe_runmake should be used and the 
default oe_runmake call already compiles xxd when calling the top level 
Makefile so there's no need for do_compile_append altogether.

The same goes for the install append.

The only thing needed to be done is simply package xxd. I'll rewrite and 
resubmit.

Thank you,
Adrian