From: Karsten Blees <karsten.blees@gmail.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions
Date: Tue, 29 Sep 2015 12:23:37 +0200 [thread overview]
Message-ID: <560A66A9.2010606@gmail.com> (raw)
In-Reply-To: <763be6c1331ac57cf7dee3636d82f994@dscho.org>
Am 28.09.2015 um 14:52 schrieb Johannes Schindelin:
> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by chance* and we assume the timestamps to be identical even if they are not.
Yeah, but in this case the file would be racy, as racy-checks use
the same comparison now.
IMO change detection is so fundamental that it should Just Work,
without having a plethora of config options that we need to explain
to end users.
If that means that once in a million cases we need an extra content
check to revalidate such falsely racy entries, that's fine with me.
Cheers,
Karsten
next prev parent reply other threads:[~2015-09-29 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 23:28 broken racy detection and performance issues with nanosecond file times Karsten Blees
2015-09-28 10:39 ` [PATCH/RFC] read-cache: fix file time comparisons with different precisions Karsten Blees
2015-09-28 12:52 ` Johannes Schindelin
2015-09-29 10:23 ` Karsten Blees [this message]
2015-09-29 13:42 ` Johannes Schindelin
2015-09-28 17:38 ` broken racy detection and performance issues with nanosecond file times Junio C Hamano
2015-09-29 11:28 ` Karsten Blees
2015-09-28 18:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A66A9.2010606@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.