From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki.Poulose@arm.com (Suzuki K. Poulose) Date: Tue, 29 Sep 2015 13:46:20 +0100 Subject: [PATCH 16/22] arm64/debug: Make use of the system wide safe value In-Reply-To: <560A8159.8000300@arm.com> References: <1442413280-31885-1-git-send-email-suzuki.poulose@arm.com> <1442413280-31885-17-git-send-email-suzuki.poulose@arm.com> <560A8159.8000300@arm.com> Message-ID: <560A881C.2020908@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/09/15 13:17, Vladimir Murzin wrote: > On 16/09/15 15:21, Suzuki K. Poulose wrote: >> From: "Suzuki K. Poulose" >> >> Use the system wide value of ID_AA64DFR0 to make safer decisions >> >> Signed-off-by: Suzuki K. Poulose >> --- >> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------ >> arch/arm64/kernel/debug-monitors.c | 6 ++++-- >> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++- >> 3 files changed, 24 insertions(+), 15 deletions(-) >> > > Looks like this patch introduces build-time regression if > CONFIG_PERF_EVENTS is not set: > >> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension': >> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps' >> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps' >> make: *** [vmlinux] Error 1 > > Vladimir > Thanks for pointing this out. I will fix it by moving the get_num_xrps() definition back to hw_breakpoint.h. Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964922AbbI2Mqc (ORCPT ); Tue, 29 Sep 2015 08:46:32 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:56764 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964787AbbI2MqX convert rfc822-to-8bit (ORCPT ); Tue, 29 Sep 2015 08:46:23 -0400 Message-ID: <560A881C.2020908@arm.com> Date: Tue, 29 Sep 2015 13:46:20 +0100 From: "Suzuki K. Poulose" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vladimir Murzin , "linux-arm-kernel@lists.infradead.org" CC: Mark Rutland , "ard.biesheuvel@linaro.org" , "aph@redhat.com" , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , "edward.nevill@linaro.org" , Andre Przywara , Marc Zyngier , Dave P Martin Subject: Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value References: <1442413280-31885-1-git-send-email-suzuki.poulose@arm.com> <1442413280-31885-17-git-send-email-suzuki.poulose@arm.com> <560A8159.8000300@arm.com> In-Reply-To: <560A8159.8000300@arm.com> X-OriginalArrivalTime: 29 Sep 2015 12:46:20.0355 (UTC) FILETIME=[D7192130:01D0FAB4] X-MC-Unique: aTgP_1ZvSY2Iu2Qhm_ip0A-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/15 13:17, Vladimir Murzin wrote: > On 16/09/15 15:21, Suzuki K. Poulose wrote: >> From: "Suzuki K. Poulose" >> >> Use the system wide value of ID_AA64DFR0 to make safer decisions >> >> Signed-off-by: Suzuki K. Poulose >> --- >> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------ >> arch/arm64/kernel/debug-monitors.c | 6 ++++-- >> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++- >> 3 files changed, 24 insertions(+), 15 deletions(-) >> > > Looks like this patch introduces build-time regression if > CONFIG_PERF_EVENTS is not set: > >> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension': >> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps' >> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps' >> make: *** [vmlinux] Error 1 > > Vladimir > Thanks for pointing this out. I will fix it by moving the get_num_xrps() definition back to hw_breakpoint.h. Suzuki