From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguXO-0004U2-69 for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZguXK-0005a6-6L for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:01:42 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:46861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguXJ-0005Zi-Ux for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:01:38 -0400 References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> <1443094669-4144-19-git-send-email-marcandre.lureau@redhat.com> From: Claudio Fontana Message-ID: <560A8BAC.8040006@huawei.com> Date: Tue, 29 Sep 2015 15:01:32 +0200 MIME-Version: 1.0 In-Reply-To: <1443094669-4144-19-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 18/47] ivshmem: improve error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com On 24.09.2015 13:37, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > The test whether the chardev is an AF_UNIX socket rejects > "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device > ivshmem,chardev=chr0", but fails to explain why. > > Use an explicit error on why a chardev may be rejected. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 71a71fc..ed1b6f7 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -301,7 +301,7 @@ static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier * > chr = qemu_chr_open_eventfd(eventfd); > > if (chr == NULL) { > - error_report("creating eventfd for eventfd %d failed", eventfd); > + error_report("creating chardriver for eventfd %d failed", eventfd); > return NULL; > } > qemu_chr_fe_claim_no_fail(chr); > @@ -778,8 +778,12 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp) > attr |= PCI_BASE_ADDRESS_MEM_TYPE_64; > } > > - if ((s->server_chr != NULL) && > - (strncmp(s->server_chr->filename, "unix:", 5) == 0)) { > + if (s->server_chr != NULL) { > + if (strncmp(s->server_chr->filename, "unix:", 5)) { > + error_setg(errp, "chardev is not a unix client socket"); > + return; > + } > + > /* if we get a UNIX socket as the parameter we will talk > * to the ivshmem server to receive the memory region */ > > Reviewed-by: Claudio Fontana