From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgv8M-0000vW-1G for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:39:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgv8I-0001gZ-0G for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:39:53 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:57235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgv8H-0001gS-Nn for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:39:49 -0400 References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> <1443094669-4144-30-git-send-email-marcandre.lureau@redhat.com> From: Claudio Fontana Message-ID: <560A94A3.7090800@huawei.com> Date: Tue, 29 Sep 2015 15:39:47 +0200 MIME-Version: 1.0 In-Reply-To: <1443094669-4144-30-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 29/47] ivshmem: error on too many eventfd received List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com On 24.09.2015 13:37, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > The number of eventfd that can be handled per peer is limited by the > number of vectors. Return an error when receiving too many of them. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index aeb8414..3231a46 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -571,6 +571,14 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size) > /* each peer has an associated array of eventfds, and we keep > * track of how many eventfds received so far */ > /* get a new eventfd: */ > + /* get a new eventfd */ > + if (peer->nb_eventfds >= s->vectors) { > + error_report("Too many eventfd received, device has %d vectors", > + s->vectors); > + close(incoming_fd); > + return; > + } > + > new_eventfd = peer->nb_eventfds++; > > /* this is an eventfd for a particular peer VM */ > Reviewed-by: Claudio Fontana