From: George Dunlap <george.dunlap@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Juergen Gross <jgross@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen: sched: adjustments to some performance counters
Date: Tue, 29 Sep 2015 15:24:02 +0100 [thread overview]
Message-ID: <560A9F02.20504@citrix.com> (raw)
In-Reply-To: <20150925095312.11655.93745.stgit@Solace.station>
On 25/09/15 10:53, Dario Faggioli wrote:
> More specifically:
>
> 1) rename vcpu_destroy to vcpu_remove
>
> It seems this have had to be done as part of 7e6b926a
> ("cpupools: Make interface more consistent"), which
> renamed the function but not the counter.
>
> In fact, because of cpupools, vcpus are not only removed
> from a scheduler when they are destroyed, but also when
> domains move between pools.
>
> Make the related statistics counter reflect that more
> properly.
>
> 2) rename vcpu_init to vcpu_alloc
>
> As it lives in *_alloc_vdata.
>
> 3) add vcpu_insert
>
> matching vcpu_remove, and useful to quickly check
> whether the number of insertions and removal matches,
> or in general investigare their relationship.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
The changeset summary is a bit vague, but I can't immediately think of a
better headline title.
Acked-by: George Dunlap <george.dunlap@citrix.com>
prev parent reply other threads:[~2015-09-29 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 9:53 [PATCH] xen: sched: adjustments to some performance counters Dario Faggioli
2015-09-25 10:19 ` Juergen Gross
2015-09-29 14:24 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A9F02.20504@citrix.com \
--to=george.dunlap@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.