From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen: sched: get rid of cpupool_scheduler_cpumask() Date: Tue, 29 Sep 2015 15:38:16 +0100 Message-ID: <560AA258.3070902@citrix.com> References: <20150924033818.26886.60191.stgit@Solace.station> <20150924034050.26886.41869.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zgw2x-0006RI-PU for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 14:38:23 +0000 In-Reply-To: <20150924034050.26886.41869.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: Juergen Gross , George Dunlap , Robert VanVossen , Joshua Whitehead , Meng Xu , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 24/09/15 04:40, Dario Faggioli wrote: > and of (almost every) direct use of cpupool_online_cpumask(). > > In fact, what we really want for the most of the times, > is the set of valid pCPUs of the cpupool a certain domain > is part of. Furthermore, in case it's called with a NULL > pool as argument, cpupool_scheduler_cpumask() does more > harm than good, by returning the bitmask of free pCPUs! > > This commit, therefore: > * gets rid of cpupool_scheduler_cpumask(), in favour of > cpupool_domain_cpumask(), which makes it more evident > what we are after, and accommodates some sanity checking; > * replaces some of the calls to cpupool_online_cpumask() > with calls to the new functions too. > > Signed-off-by: Dario Faggioli > Acked-by: Juergen Gross > Acked-by: Joshua Whitehead > Reviewed-by: Meng Xu Right, sorry about not getting back to the new version. Looks good: Reviewed-by: George Dunlap