From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryusuke Konishi Subject: Re: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid_dev check Date: Tue, 29 Sep 2015 23:51:24 +0900 Message-ID: <560AA56C.4020209@lab.ntt.co.jp> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443450823-5692-1-git-send-email-bywxiaobai@163.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1443450823-5692-1-git-send-email-bywxiaobai-9Onoh4P/yGk@public.gmane.org> Sender: linux-nilfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Yaowei Bai , viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 2015/09/28 23:33, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai Acked-by: Ryusuke Konishi > --- > fs/nilfs2/namei.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c > index 37dd6b0..c9a1a49 100644 > --- a/fs/nilfs2/namei.c > +++ b/fs/nilfs2/namei.c > @@ -120,9 +120,6 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev) > struct nilfs_transaction_info ti; > int err; > > - if (!new_valid_dev(rdev)) > - return -EINVAL; > - > err = nilfs_transaction_begin(dir->i_sb, &ti, 1); > if (err) > return err; > -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933082AbbI2PPi (ORCPT ); Tue, 29 Sep 2015 11:15:38 -0400 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:43906 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbbI2PPa (ORCPT ); Tue, 29 Sep 2015 11:15:30 -0400 X-Greylist: delayed 1433 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Sep 2015 11:15:29 EDT Subject: Re: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid_dev check To: Yaowei Bai , viro@zeniv.linux.org.uk References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443450823-5692-1-git-send-email-bywxiaobai@163.com> Cc: linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org From: Ryusuke Konishi Organization: NTT OSS Center Message-ID: <560AA56C.4020209@lab.ntt.co.jp> Date: Tue, 29 Sep 2015 23:51:24 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443450823-5692-1-git-send-email-bywxiaobai@163.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/09/28 23:33, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai Acked-by: Ryusuke Konishi > --- > fs/nilfs2/namei.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c > index 37dd6b0..c9a1a49 100644 > --- a/fs/nilfs2/namei.c > +++ b/fs/nilfs2/namei.c > @@ -120,9 +120,6 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev) > struct nilfs_transaction_info ti; > int err; > > - if (!new_valid_dev(rdev)) > - return -EINVAL; > - > err = nilfs_transaction_begin(dir->i_sb, &ti, 1); > if (err) > return err; >