From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCHv4 2/9] null: fix segfault when null_pmd added
 to bonding
Date: Wed, 30 Sep 2015 10:24:39 +0900
Message-ID: <560B39D7.6090708@igel.co.jp>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com>
 <5609F65A.6050208@igel.co.jp>
 <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com>
 <560A68DA.4060309@igel.co.jp>
 <3042915272161B4EB253DA4D77EB373A14DF7CCD@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id B663E5A45
 for <dev@dpdk.org>; Wed, 30 Sep 2015 03:24:42 +0200 (CEST)
Received: by padhy16 with SMTP id hy16so22162744pad.1
 for <dev@dpdk.org>; Tue, 29 Sep 2015 18:24:42 -0700 (PDT)
In-Reply-To: <3042915272161B4EB253DA4D77EB373A14DF7CCD@IRSMSX102.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/09/30 0:10, Kulasek, TomaszX wrote:
> Hi Tetsuya,
>
> Changes from patch below, solves the problem. I've removed malloc.
>
> Tomasz.
>
> ---
> From e03e77a7dc0e47ac9d750545a834624f88f61966 Mon Sep 17 00:00:00 2001
> From: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> Date: Tue, 29 Sep 2015 16:48:31 +0200
> Subject: [PATCH 1/4] null: fix segfault when null_pmd added to bonding
>
> ---
>  drivers/net/null/rte_eth_null.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index e244595..b498ef1 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -432,6 +432,7 @@ eth_dev_null_create(const char *name,
>  	internals->numa_node = numa_node;
>  
>  	pci_dev->numa_node = numa_node;
> +	pci_dev->driver = &rte_null_pmd.pci_drv;
>  
>  	data->dev_private = internals;
>  	data->port_id = eth_dev->data->port_id;
> @@ -445,6 +446,7 @@ eth_dev_null_create(const char *name,
>  	eth_dev->dev_ops = &ops;
>  	eth_dev->pci_dev = pci_dev;
>  	eth_dev->driver = &rte_null_pmd;
> +	TAILQ_INIT(&eth_dev->link_intr_cbs);
>  
>  	/* finally assign rx and tx ops */
>  	if (packet_copy) {
> @@ -461,6 +463,7 @@ error:
>  	rte_free(data);
>  	rte_free(pci_dev);
>  	rte_free(internals);
> +	rte_free(eth_dev);

Hi Tomasz,

We can remove rte_free(eth_dev), because if eth_dev is allocated
correctly, we cannot reach here.
I don't see any issues except for it.

Thanks,
Tetsuya