From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: Zhao Lei <zhaolei@cn.fujitsu.com>, dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix a compiler warning of may be used uninitialized
Date: Wed, 30 Sep 2015 10:18:39 +0200 [thread overview]
Message-ID: <560B9ADF.3050503@googlemail.com> (raw)
In-Reply-To: <00d701d0fb33$cfbc6a80$6f353f80$@cn.fujitsu.com>
On 09/30/15 05:55, Zhao Lei wrote:
>> count is defined iff add_to_ctl == true, so the patch is not necessary. And I'm
>> not quite sure that 0 passed down to __btrfs_add_free_space as 'bytes' makes
>> sense at all.
>
> Agree above all.
>
> So I write following description in changelog:
> "Not real problem, just avoid warning of: ..."
>
> It is just to avoid complier warning, no function changed.
> A warning in compiler output is not pretty:)
This looks more like a false-positive with gcc 4.8.3.
With 5.2:
..
CC [M] fs/btrfs/file-item.o
CC [M] fs/btrfs/inode-item.o
CC [M] fs/btrfs/inode-map.o
CC [M] fs/btrfs/disk-io.o
CC [M] fs/btrfs/transaction.o
..
No warning, as expected.
-h
next prev parent reply other threads:[~2015-09-30 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 7:19 [PATCH] btrfs: fix a compiler warning of may be used uninitialized Zhao Lei
2015-09-29 14:21 ` David Sterba
2015-09-30 3:55 ` Zhao Lei
2015-09-30 8:18 ` Holger Hoffstätte [this message]
2015-09-30 14:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560B9ADF.3050503@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.