From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 681BFE00F45; Wed, 30 Sep 2015 03:09:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.169 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id A17FDE00C27 for ; Wed, 30 Sep 2015 03:09:36 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so187463254wic.1 for ; Wed, 30 Sep 2015 03:09:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=5TExEuF4IEupWRBPHk6hOng5FZzJPJfoCrx08xdILr8=; b=PJxn7Eiy1d1XouVHEli2YLjZYEAwE1Xcepg+23GpZbwXwdEIayzaDRlX+oiIbJ28xd sSTZ9fU328/fd1DaPHWROgHzGrW+s+2VsyHcB++2wcOioH8ouXNvqxhvrm4A8VzLTcR8 a6BzIxpG1uLVkmkW4fnLHBXdmVh5lU4aKLWRUKC1NgHb+5Kt3ZdrbwekMJWxYiZA+7bc eV+y2xjYzJz0n3+Q4BXllVLfFO75xU9pf8ffuupkDhtuX4fp5H8wKx5qP6oHFVbDln6Q Pxy5FiS8kd40nxreMRi3wCMVq3IbFYFML0mTnBK3jk80Dc37CxOkDouU5owYGUSTnOuo fa6Q== X-Gm-Message-State: ALoCoQkR6xRK62908fJU30AadmEU4AYemlpOHYHKloDXA15PlKWvkTlMpFq5BaC2sOdEs29XL1h+ X-Received: by 10.194.87.74 with SMTP id v10mr3007326wjz.114.1443607775479; Wed, 30 Sep 2015 03:09:35 -0700 (PDT) Received: from [192.168.2.178] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id q1sm389366wje.39.2015.09.30.03.09.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Sep 2015 03:09:34 -0700 (PDT) To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <1443543524-26744-1-git-send-email-michael.g.wood@intel.com> From: Michael Wood Message-ID: <560BB4DE.7040405@intel.com> Date: Wed, 30 Sep 2015 11:09:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] toaster: orm Machines filter don't pass self in as parameter X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 10:09:37 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 30/09/15 10:21, Barros Pena, Belen wrote: > > On 29/09/2015 17:18, "toaster-bounces@yoctoproject.org on behalf of > Michael Wood" michael.g.wood@intel.com> wrote: > >> Fix typo don't pass self in as a parameter, this evaluated to true >> giving the wrong results meaning the machines typeahead did not return >> valid results. > I am not sure if it is connected to this problem, but I can only set > machines if I select one of the type ahead suggestions. This is not the > correct behaviour. Machines are like build targets: we can never be sure > that Toaster knows of all valid options. Therefore, we need to allow free > text entry. This is controlled by the project page so not related to this. Feel free to open a bug. > Right now, if type some random string in the machine field then click > 'save', Toaster reverts to the previous value and refuses to take the new > one. This also means that, for a local project, where we don't have any > information about machines, it is impossible to change the machine value. > > Cheers, > > Belén > >> Signed-off-by: Michael Wood >> --- >> bitbake/lib/toaster/orm/models.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/bitbake/lib/toaster/orm/models.py >> b/bitbake/lib/toaster/orm/models.py >> index 5aed158..f5529e2 100644 >> --- a/bitbake/lib/toaster/orm/models.py >> +++ b/bitbake/lib/toaster/orm/models.py >> @@ -229,7 +229,7 @@ class Project(models.Model): >> """ Returns QuerySet of all Machines which are provided by the >> Layers currently added to the Project """ >> queryset = Machine.objects.filter( >> - layer_version__in=self.get_project_layer_versions(self)) >> + layer_version__in=self.get_project_layer_versions()) >> >> return queryset >> >> -- >> 2.1.4 >> >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster