From: jc@eclis.ch (Jean-Christian de Rivaz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
Date: Wed, 30 Sep 2015 12:13:33 +0200 [thread overview]
Message-ID: <560BB5CD.1040908@eclis.ch> (raw)
In-Reply-To: <20150930061002.GI3982@pengutronix.de>
Le 30. 09. 15 08:10, Uwe Kleine-K?nig a ?crit :
> Hello,
>
> On Wed, Sep 30, 2015 at 12:32:48AM +0200, jc at eclis.ch wrote:
>> From: Jean-Christian de Rivaz <jc@eclis.ch>
>>
>> According to Russell King:
>> In any case, unless you have a Marvell platform, you should have this
>> disabled - it provides a performance boost for Marvell platforms, but
>> degrades performance everywhere else. Please ensure that you disable
>> CONFIG_UACCESS_WITH_MEMCPY.
>>
>> Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
> the change is fine now. Feel free to add my Ack also if you do another
> round to improve the changelog.
>
> Best regards
> Uwe
>
Thanks Uwe,
Nicolas and Russell, for my own curiosity I tested the difference on
this system:
# cat /proc/cpuinfo
processor : 0
model name : ARMv7 Processor rev 1 (v7l)
BogoMIPS : 348.97
Features : half thumb fastmult vfp edsp vfpv3 vfpv3d16 tls vfpv4
CPU implementer : 0x41
CPU architecture: 7
CPU variant : 0x0
CPU part : 0xc05
CPU revision : 1
Hardware : Atmel SAMA5
Revision : 0000
Serial : 0000000000000000
# dd if=/dev/zero of=/dev/null bs=4k count=1M
Take about 10 seconds to complete on this system and report the
following speed in MB/s in 10 rounds:
CONFIG_UACCESS_WITH_MEMCPY=y
470, 419, 440, 446, 434, 437, 418, 412, 431, 437
# CONFIG_UACCESS_WITH_MEMCPY disabled is not set
387, 387, 382, 383, 385, 388, 387, 387, 384, 386
So It look like this feature still give some advantage on system other
than Orion CPU core. I still propose my patch to disable it until it's
rock stable as it used to be a least with the kernel 3.19.0.
Regards,
Jean-Christian
next prev parent reply other threads:[~2015-09-30 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 22:32 [PATCH 1/1] Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config jc at eclis.ch
2015-09-30 6:10 ` Uwe Kleine-König
2015-09-30 10:13 ` Jean-Christian de Rivaz [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-29 20:03 jc at eclis.ch
2015-09-29 20:13 ` Nicolas Pitre
2015-09-29 20:35 ` Uwe Kleine-König
2015-09-29 20:59 ` Jean-Christian de Rivaz
2015-09-29 22:01 ` Alexandre Belloni
2015-09-29 22:18 ` Russell King - ARM Linux
2015-09-29 22:53 ` Alexandre Belloni
2015-09-29 23:19 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BB5CD.1040908@eclis.ch \
--to=jc@eclis.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.