From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: Having troubles binding an SR-IOV VF to uio_pci_generic on Amazon instance Date: Wed, 30 Sep 2015 13:37:22 +0300 Message-ID: <560BBB62.3050502@cloudius-systems.com> References: <56079527.3000802@cloudius-systems.com> <20150927123914-mutt-send-email-mst@redhat.com> <560ABF25.9030300@cloudius-systems.com> <20150929235122-mutt-send-email-mst@redhat.com> <20150929144616.4e70b44c@urahara> <20150930004714-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Michael S. Tsirkin" , Stephen Hemminger Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 999328D95 for ; Wed, 30 Sep 2015 12:37:29 +0200 (CEST) Received: by wiclk2 with SMTP id lk2so191218027wic.0 for ; Wed, 30 Sep 2015 03:37:29 -0700 (PDT) In-Reply-To: <20150930004714-mutt-send-email-mst@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/30/15 00:49, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2015 at 02:46:16PM -0700, Stephen Hemminger wrote: >> On Tue, 29 Sep 2015 23:54:54 +0300 >> "Michael S. Tsirkin" wrote: >> >>> On Tue, Sep 29, 2015 at 07:41:09PM +0300, Vlad Zolotarov wrote: >>>> The security breach motivation u brought in "[RFC PATCH] uio: >>>> uio_pci_generic: Add support for MSI interrupts" thread seems a bit weak >>>> since one u let the userland access to the bar it may do any funny thing >>>> using the DMA engine of the device. This kind of stuff should be prevented >>>> using the iommu and if it's enabled then any funny tricks using MSI/MSI-X >>>> configuration will be prevented too. >>>> >>>> I'm about to send the patch to main Linux mailing list. Let's continue this >>>> discussion there. >>>> >>> Basically UIO shouldn't be used with devices capable of DMA. >>> Use VFIO for that (yes, this implies an emulated or PV IOMMU). If there is an IOMMU in the picture there shouldn't be any problem to use UIO with DMA capable devices. >>> I don't think this can change. >> Given there is no PV IOMMU and even if there was it would be too slow for DPDK >> use, I can't accept that. > QEMU does allow emulating an iommu. Amazon's EC2 xen HV doesn't. At least today. Therefore VFIO is not an option there. And again, it's a general issue not DPDK specific. Today one has to develop some proprietary modules (like igb_uio) to workaround the issue and this is lame. IMHO uio_pci_generic should be fixed to be able to properly work within any virtualized environment and not only with KVM. > DPDK uses static mappings, so I > doubt it's speed matters at all. > > Anyway, DPDK is doing polling all the time. I don't see why does it > insist on using interrupts to detect link up events. Just poll for that > too. >