From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Correctly read the GICv3 Re-Distributor stride Date: Wed, 30 Sep 2015 12:11:44 +0100 Message-ID: <560BC370.5030900@citrix.com> References: <560BBF70.7030205@huawei.com> <1443611055.16718.184.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZhFJs-0008Me-1K for xen-devel@lists.xenproject.org; Wed, 30 Sep 2015 11:13:08 +0000 In-Reply-To: <1443611055.16718.184.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Shameerali Kolothum Thodi , xen-devel@lists.xenproject.org Cc: vijaya.kumar@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 30/09/15 12:04, Ian Campbell wrote: > On Wed, 2015-09-30 at 11:54 +0100, Shameerali Kolothum Thodi wrote: >> The GICv3 driver read a 32 bit value for the re-distributor stride, but >> the dts binding is a two-cell property. > > The binding doc I have says: > > - redistributor-stride : If using padding pages, specifies the stride > of consecutive redistributors. Must be a multiple of 64kB. > > i.e. it doesn't say anything about the size. The _example_ is 2 cells, but > I don't think that is normative. > > Unless you can point to a bindings update which specifies strictly two > cells then I think the right answer is the use dt_read_number. FWIW Linux is using of_property_read_u64 to get the stride. It has always been the case and I don't understand how we end up to use dt_property_u32 in Xen as we port the driver from Linux... So before using dt_read_number in Xen, I would rather check if the DT binding is not clear enough or the Linux drivers doesn't respect the binding. Regards, -- Julien Grall