From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhIiP-0004Qb-My for qemu-devel@nongnu.org; Wed, 30 Sep 2015 10:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhIiL-0001sI-GC for qemu-devel@nongnu.org; Wed, 30 Sep 2015 10:50:41 -0400 References: <1442497700-2536-1-git-send-email-kwolf@redhat.com> <1442497700-2536-16-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <560BF6B6.5030608@redhat.com> Date: Wed, 30 Sep 2015 16:50:30 +0200 MIME-Version: 1.0 In-Reply-To: <1442497700-2536-16-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q6IfiRIhw3LkKdXPEL2FdU8rBDt6B0TVW" Subject: Re: [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, berto@igalia.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q6IfiRIhw3LkKdXPEL2FdU8rBDt6B0TVW Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.09.2015 15:48, Kevin Wolf wrote: > This cleans up the mess we left behind in the mirror code after the > previous patch. Instead of using bdrv_swap(), just change pointers. >=20 > The interface change of the mirror job that callers must consider is > that after job completion, their local BDS pointers still point to the > same node now. qemu-img must change its code accordingly (which makes i= t > easier to understand); the other callers stays unchanged because after > completion they don't do anything with the BDS, but just with the job, > and the job is still owned by the source BDS. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 23 +++++++---------------- > include/block/block.h | 4 +++- > qemu-img.c | 16 ++++++++-------- > 4 files changed, 49 insertions(+), 26 deletions(-) Reviewed-by: Max Reitz --Q6IfiRIhw3LkKdXPEL2FdU8rBDt6B0TVW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWC/a2AAoJEDuxQgLoOKytzOsH/3K1jf95rzQ7BfdRdhRbWsck MX9QuUx+oKtjICVjMVpu5+UfRJ96uM46rnxPLWVvHFraSvmKXWbBekzVXCtQJmTR K45CnDbLQjYY9MgmYIVBTiu8r1QsxhBdXIiM5BERT7MxSDF4iEWfeqZJIvjkUJhK brOVns4Fdc+NY8ijLjAjzI0d91ALdqJI5jNcpDC2Z7deMdXXy71PlBVrfOREZdU7 SZ1R5vrgQ0zR94+H7Di9+nU2lVmBry5kEVBHcJ0Q0ooENdiaaN5gKmOvQSG/dpxB yBETdPkTBTUj151+8KJM/P6hZgcioMRO+iHbvrpy08ZeWFAYdvDaGGqD0y284KA= =nbde -----END PGP SIGNATURE----- --Q6IfiRIhw3LkKdXPEL2FdU8rBDt6B0TVW--