From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH] xen: Bump __XEN_LATEST_INTERFACE_VERSION__ to 0x00040700 Date: Wed, 30 Sep 2015 18:38:26 +0300 Message-ID: <560C01F2.9040002@bitdefender.com> References: <1443626219-1743-1-git-send-email-rcojocaru@bitdefender.com> <560BFEFE.3050901@citrix.com> <560BFFA7.8030001@bitdefender.com> <560C1D3702000078000A730F@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <560C1D3702000078000A730F@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Julien Grall Cc: keir@xen.org, tim@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/30/2015 06:34 PM, Jan Beulich wrote: >>>> On 30.09.15 at 17:28, wrote: >> On 09/30/2015 06:25 PM, Julien Grall wrote: >>> Hi, >>> >>> On 30/09/15 16:16, Razvan Cojocaru wrote: >>>> VM_EVENT_FLAG_SET_REGISTERS and xc_monitor_emulate_each_rep() are >>>> not available in Xen 4.6, hence the bump. >>> >>> Shouldn't you bump XEN_DOMCTL_INTERFACE_VERSION and >>> VM_EVENT_INTERFACE_VERSION instead? >>> >>> The former for xc_monitor_emulate_each_read as it's a DOMCTL and the >>> latter for VM_EVENT_FLAG_SET_REGISTERS? >> >> Yes, judging also by Jan's previous comment that would appear to be the >> preferred way to go. > > I can't talk about VM_EVENT_INTERFACE_VERSION, but I also > don't see any reason to bump XEN_DOMCTL_INTERFACE_VERSION > with the given change. Again - it's just an addition to the interface, > not an incompatible change. The same is true for VM_EVENT_FLAG_SET_REGISTERS I'm afraid. Nothing at all changes for existing vm_event users. In that case, I'll just leave them all alone. But the question still remains, if these markers are unreliable in my case, could you please suggest another which I can check in my scenario? __XEN_LATEST_INTERFACE_VERSION__ has been fine so far, but I now see that this has only been a coincidence. Thanks, Razvan