From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932663AbbI3RoO (ORCPT ); Wed, 30 Sep 2015 13:44:14 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35053 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbbI3RoL (ORCPT ); Wed, 30 Sep 2015 13:44:11 -0400 Message-ID: <560C1F5A.5070506@gmail.com> Date: Wed, 30 Sep 2015 10:43:54 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Neil Armstrong , "David S. Miller" , Jesper Dangaard Brouer CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux@roeck-us.net Subject: Re: [RFC PATCH 0/3] net: dsa: Complete and fix the dsa unbinding References: <560B9B70.6030202@baylibre.com> In-Reply-To: <560B9B70.6030202@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/15 01:21, Neil Armstrong wrote: > In order to cleanly unbind the dsa core, either as a module removal, > or a platform device unbind, switch the allocation the their devm_ > counterparts and complete the destroy functions. > > The last patch is an experimental way to exit the probe when no > switch is found in the discover process. > > The patches are based on the current net-next. I looked at the patches and they bring DSA in a better direction. For future submissions, could you CC people who recently worked on DSA, like Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically give your patches a try fairly quickly. In case you are seriously considering making DSA a loadable module, there were an earlier attempt here: http://comments.gmane.org/gmane.linux.network/345803 Thanks! > > Neil Armstrong (3): > net: dsa: Use devm_ prefixed allocations > net: dsa: complete dsa_switch_destroy calls > net: dsa: exit probe if no switch were found > > net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 60 insertions(+), 7 deletions(-) > -- Florian