From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZhQje-0007ZN-5e
	for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:24:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZhQjb-0007US-0F
	for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:24:30 -0400
Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:36192)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZhQja-0007UK-QZ
	for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:24:26 -0400
Received: by pablk4 with SMTP id lk4so53464833pab.3
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2015 16:24:26 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1443627027-2193-1-git-send-email-james.hogan@imgtec.com>
	<1443627027-2193-6-git-send-email-james.hogan@imgtec.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <560C6F21.5090503@twiddle.net>
Date: Thu, 1 Oct 2015 09:24:17 +1000
MIME-Version: 1.0
In-Reply-To: <1443627027-2193-6-git-send-email-james.hogan@imgtec.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/7] tcg/mips: Support r6 multiply/divide
	encodings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>, qemu-devel@nongnu.org
Cc: Leon Alrae <leon.alrae@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>

On 10/01/2015 01:30 AM, James Hogan wrote:
>       case INDEX_op_mul_i32:
> +        if (use_mips32r6_instructions) {
> +            tcg_out_opc_reg(s, OPC_MUL_R6, a0, a1, a2);
> +            break;
> +        }
>           if (use_mips32_instructions) {
>               tcg_out_opc_reg(s, OPC_MUL, a0, a1, a2);
>               break;

I wonder if it's worth defining a common OPC_MUL as you did with OPC_JR.
Also, these columns aren't lining up.  Did you use tabs?


r~