From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 2/3] leds: add debugfs to device trigger Date: Thu, 01 Oct 2015 09:36:00 +0200 Message-ID: <560CE260.1000404@samsung.com> References: <560BECCE.6080304@samsung.com> <20150930154754.GA31149@corsair.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150930154754.GA31149@corsair.lan> Sender: linux-kernel-owner@vger.kernel.org To: Maciek Borzecki Cc: linux-kernel@vger.kernel.org, Richard Purdie , linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet List-Id: linux-leds@vger.kernel.org On 09/30/2015 05:47 PM, Maciek Borzecki wrote: > On 09/30 16:08, Jacek Anaszewski wrote: >> Hi Maciek, >> >> Please test your solution thoroughly before submitting >> the next version. Writing to debugfs register attribute >> fails due to lack of proper copying from user memory, >> which makes testing impossible. > > Hi, thanks for the comment. Indeed, I noticed the problem just after > sending the patch. Surprisingly this didn't fail on iMX6 for some > reason. > > Aside from the __user access problem, is the approach, in general, ok for > you or would you suggest that I changed something? At first glance the feature looks nice. I'll be able to say more after testing working version. -- Best Regards, Jacek Anaszewski