From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Tudor Date: Thu, 01 Oct 2015 09:12:30 +0000 Subject: Re: [PATCH 1/2] KVM: PPC: e6500: Handle LRAT error exception Message-Id: <560CF8FE.50603@freescale.com> List-Id: References: <5603F684.9020501@freescale.com> In-Reply-To: <5603F684.9020501@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On 09/30/2015 01:32 PM, Laurentiu Tudor wrote: > On 09/25/2015 03:10 AM, Scott Wood wrote: >> On Thu, 2015-09-24 at 16:11 +0300, Laurentiu Tudor wrote: [snip] >>> diff --git a/arch/powerpc/kvm/e500_mmu_host.c >>> b/arch/powerpc/kvm/e500_mmu_host.c >>> index 12d5c67..99ad88a 100644 >>> --- a/arch/powerpc/kvm/e500_mmu_host.c >>> +++ b/arch/powerpc/kvm/e500_mmu_host.c >>> @@ -96,6 +96,112 @@ static inline void __write_host_tlbe(struct >>> kvm_book3e_206_tlb_entry *stlbe, >>> stlbe->mas2, stlbe->mas7_3); >>> } >>> >>> +#if defined(CONFIG_64BIT) && defined(CONFIG_KVM_BOOKE_HV) >>> +static int lrat_next(void) >>> +{ >> >> Will anything break by removing the CONFIG_64BIT condition, even if we don't >> have a 32-bit target that uses this? > > Not completly certain but i remember getting compile or link errors > on 32-bit e500mc or e500v2. I can recheck if you want. > I double-checked this and indeed it doesn't compile on 32-bit because lrat_next() calls get_paca(). --- Best Regards, Laurentiu