From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756459AbbJALsB (ORCPT ); Thu, 1 Oct 2015 07:48:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:40061 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755430AbbJALr5 (ORCPT ); Thu, 1 Oct 2015 07:47:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,617,1437462000"; d="scan'208";a="781777871" Subject: Re: [PATCH 17/25] perf callchain: Allow for max_stack greater than PERF_MAX_STACK_DEPTH To: Arnaldo Carvalho de Melo References: <1443186956-18718-1-git-send-email-adrian.hunter@intel.com> <1443186956-18718-18-git-send-email-adrian.hunter@intel.com> <20150928200810.GC9392@kernel.org> <560A48D5.7010901@intel.com> Cc: Jiri Olsa , linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <560D1CBD.4050809@intel.com> Date: Thu, 1 Oct 2015 14:45:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <560A48D5.7010901@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/15 11:16, Adrian Hunter wrote: > On 28/09/15 23:08, Arnaldo Carvalho de Melo wrote: >> Em Fri, Sep 25, 2015 at 04:15:48PM +0300, Adrian Hunter escreveu: >>> Adjust the validation to allow for max_stack greater than >>> PERF_MAX_STACK_DEPTH. >>> >>> Signed-off-by: Adrian Hunter >>> --- >>> tools/perf/util/machine.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c >>> index fd1efeafb343..d7bd9a304535 100644 >>> --- a/tools/perf/util/machine.c >>> +++ b/tools/perf/util/machine.c >>> @@ -1831,7 +1831,7 @@ static int thread__resolve_callchain_sample(struct thread *thread, >>> } >>> >>> check_calls: >>> - if (chain->nr > PERF_MAX_STACK_DEPTH) { >>> + if (chain->nr > PERF_MAX_STACK_DEPTH && (int)chain->nr > max_stack) { >> >> Both? > > Yes. > > In the case of a hardware generated callchain, the callchain can be up to > PERF_MAX_STACK_DEPTH but max_stack can be less than PERF_MAX_STACK_DEPTH to > limit the number processed. > > In the case of a synthesized callchain, the callchain can be up to max_stack > which might be more than PERF_MAX_STACK_DEPTH. Is this ok? > >> >>> pr_warning("corrupted callchain. skipping...\n"); >>> return 0; >>> } >>> -- >>> 1.9.1 >> > >