From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/7] xen/arm: Warn when a device tree path will be re-used by Xen Date: Thu, 1 Oct 2015 13:39:23 +0100 Message-ID: <560D297B.7000107@citrix.com> References: <1443543701-18389-1-git-send-email-julien.grall@citrix.com> <1443543701-18389-4-git-send-email-julien.grall@citrix.com> <1443700889.11707.24.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZhdAL-0008Vg-Jy for xen-devel@lists.xenproject.org; Thu, 01 Oct 2015 12:40:53 +0000 In-Reply-To: <1443700889.11707.24.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 01/10/15 13:01, Ian Campbell wrote: > On Tue, 2015-09-29 at 17:21 +0100, Julien Grall wrote: >> Xen is unconditionally using certain device tree paths to create DOM0 >> specific node (for instance /psci, /memory and /hypervisor). >> >> Print a warning message on the console to let the user know if we >> re-use one of these nodes. >> >> Note that the content of most of those is very common and they >> should have already been skipped via the compatible string or typer > > Stray "r" at the end (fixable on commit) > >> string. This warning is here to catch unusual device-tree and >> compatible string that we may not yet support in Xen. >> >> Signed-off-by: Julien Grall > > Acked-by: Ian Campbell > > Should we consider using /xen-psci or something to avoid this conflict? Or > (worse IMHO) adding a -N until we find an unused path? If the /psci node is not removed because it uses a compatible string which we don't support (i.e arm,psci-1.0 or else), we would end up having 2 PSCI nodes in the DT. This would be harder to catch the problem in the DT. So I think we should stay with the current name. Regards, -- Julien Grall