From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:58325 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753612AbbJAOug (ORCPT ); Thu, 1 Oct 2015 10:50:36 -0400 Subject: Re: [PATCH] drm: Hack around CONFIG_AGP=m build failures References: <1443682119-17011-1-git-send-email-daniel.vetter@ffwll.ch> <8737xvc87a.fsf@intel.com> <560D03C8.70309@suse.com> <20151001101757.GV3383@phenom.ffwll.local> From: Michal Marek Message-ID: <560D4839.3050706@suse.com> Date: Thu, 1 Oct 2015 16:50:33 +0200 MIME-Version: 1.0 In-Reply-To: <20151001101757.GV3383@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Daniel Vetter Cc: Jani Nikula , Daniel Vetter , DRI Development , Stephen Rothwell , linux-kbuild@vger.kernel.org, Daniel Vetter On 2015-10-01 12:17, Daniel Vetter wrote: > On Thu, Oct 01, 2015 at 11:58:32AM +0200, Michal Marek wrote: >> On 2015-10-01 10:19, Jani Nikula wrote: >>> On Thu, 01 Oct 2015, Daniel Vetter wrote: >>>> Surprisingly kbuild can't cope with tristates in the >>>> -$(CONFIG_FOO) pattern. This patch hacks up a solution. >>> >>> Given that it's two distinct Makefile variables (foo-y and foo-m) being >>> assigned to, I don't really find this surprising. Maybe this could be >>> made to work as a convenience, but there might be other, more surpising >>> consequences. >> >> I actually think that kbuild should be able to handle this. The likely >> reason why it is not doing it right now is that in an ideal world, >> modules are modules can be built out of tree against just the kernel and >> their static dependencies. In real world, we sometimes have features in >> modules that are enabled if other modules are enabled. I'll post a patch >> later. We also have lots of tests fo CONFIG_FOO || CONFIG_FOO_MODULE in >> built-in code, which is a similar case. > > Cool. I'll keep this hack in drm-misc then. Please cc me on the proper > solution so I know when I can revert it again. It's not as trivial as it seemed, because there are at least three Makefiles that rely on the current behavior: init/Makefile drivers/misc/ibmasm/Makefile fs/logfs/Makefile While ibmasm and logfs can and probably should be fixed to work with modular 8250 and mtd, respectively, init/Makefile would need a workaround to only pick up do_mounts_rd.o and do_mounts_md.o if the respective block drivers are built-in. So we would be trading one hack for another. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Marek Subject: Re: [PATCH] drm: Hack around CONFIG_AGP=m build failures Date: Thu, 1 Oct 2015 16:50:33 +0200 Message-ID: <560D4839.3050706@suse.com> References: <1443682119-17011-1-git-send-email-daniel.vetter@ffwll.ch> <8737xvc87a.fsf@intel.com> <560D03C8.70309@suse.com> <20151001101757.GV3383@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E89B6E43E for ; Thu, 1 Oct 2015 07:50:36 -0700 (PDT) In-Reply-To: <20151001101757.GV3383@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Stephen Rothwell , linux-kbuild@vger.kernel.org, Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gMjAxNS0xMC0wMSAxMjoxNywgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIE9jdCAw MSwgMjAxNSBhdCAxMTo1ODozMkFNICswMjAwLCBNaWNoYWwgTWFyZWsgd3JvdGU6Cj4+IE9uIDIw MTUtMTAtMDEgMTA6MTksIEphbmkgTmlrdWxhIHdyb3RlOgo+Pj4gT24gVGh1LCAwMSBPY3QgMjAx NSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6Cj4+Pj4gU3Vy cHJpc2luZ2x5IGtidWlsZCBjYW4ndCBjb3BlIHdpdGggdHJpc3RhdGVzIGluIHRoZQo+Pj4+IDxt b2R1bGU+LSQoQ09ORklHX0ZPTykgcGF0dGVybi4gVGhpcyBwYXRjaCBoYWNrcyB1cCBhIHNvbHV0 aW9uLgo+Pj4KPj4+IEdpdmVuIHRoYXQgaXQncyB0d28gZGlzdGluY3QgTWFrZWZpbGUgdmFyaWFi bGVzIChmb28teSBhbmQgZm9vLW0pIGJlaW5nCj4+PiBhc3NpZ25lZCB0bywgSSBkb24ndCByZWFs bHkgZmluZCB0aGlzIHN1cnByaXNpbmcuIE1heWJlIHRoaXMgY291bGQgYmUKPj4+IG1hZGUgdG8g d29yayBhcyBhIGNvbnZlbmllbmNlLCBidXQgdGhlcmUgbWlnaHQgYmUgb3RoZXIsIG1vcmUgc3Vy cGlzaW5nCj4+PiBjb25zZXF1ZW5jZXMuCj4+Cj4+IEkgYWN0dWFsbHkgdGhpbmsgdGhhdCBrYnVp bGQgc2hvdWxkIGJlIGFibGUgdG8gaGFuZGxlIHRoaXMuIFRoZSBsaWtlbHkKPj4gcmVhc29uIHdo eSBpdCBpcyBub3QgZG9pbmcgaXQgcmlnaHQgbm93IGlzIHRoYXQgaW4gYW4gaWRlYWwgd29ybGQs Cj4+IG1vZHVsZXMgYXJlIG1vZHVsZXMgY2FuIGJlIGJ1aWx0IG91dCBvZiB0cmVlIGFnYWluc3Qg anVzdCB0aGUga2VybmVsIGFuZAo+PiB0aGVpciBzdGF0aWMgZGVwZW5kZW5jaWVzLiBJbiByZWFs IHdvcmxkLCB3ZSBzb21ldGltZXMgaGF2ZSBmZWF0dXJlcyBpbgo+PiBtb2R1bGVzIHRoYXQgYXJl IGVuYWJsZWQgaWYgb3RoZXIgbW9kdWxlcyBhcmUgZW5hYmxlZC4gSSdsbCBwb3N0IGEgcGF0Y2gK Pj4gbGF0ZXIuIFdlIGFsc28gaGF2ZSBsb3RzIG9mIHRlc3RzIGZvIENPTkZJR19GT08gfHwgQ09O RklHX0ZPT19NT0RVTEUgaW4KPj4gYnVpbHQtaW4gY29kZSwgd2hpY2ggaXMgYSBzaW1pbGFyIGNh c2UuCj4gCj4gQ29vbC4gSSdsbCBrZWVwIHRoaXMgaGFjayBpbiBkcm0tbWlzYyB0aGVuLiBQbGVh c2UgY2MgbWUgb24gdGhlIHByb3Blcgo+IHNvbHV0aW9uIHNvIEkga25vdyB3aGVuIEkgY2FuIHJl dmVydCBpdCBhZ2Fpbi4KCkl0J3Mgbm90IGFzIHRyaXZpYWwgYXMgaXQgc2VlbWVkLCBiZWNhdXNl IHRoZXJlIGFyZSBhdCBsZWFzdCB0aHJlZQpNYWtlZmlsZXMgdGhhdCByZWx5IG9uIHRoZSBjdXJy ZW50IGJlaGF2aW9yOgoKaW5pdC9NYWtlZmlsZQpkcml2ZXJzL21pc2MvaWJtYXNtL01ha2VmaWxl CmZzL2xvZ2ZzL01ha2VmaWxlCgpXaGlsZSBpYm1hc20gYW5kIGxvZ2ZzIGNhbiBhbmQgcHJvYmFi bHkgc2hvdWxkIGJlIGZpeGVkIHRvIHdvcmsgd2l0aAptb2R1bGFyIDgyNTAgYW5kIG10ZCwgcmVz cGVjdGl2ZWx5LCBpbml0L01ha2VmaWxlIHdvdWxkIG5lZWQgYQp3b3JrYXJvdW5kIHRvIG9ubHkg cGljayB1cCBkb19tb3VudHNfcmQubyBhbmQgZG9fbW91bnRzX21kLm8gaWYgdGhlCnJlc3BlY3Rp dmUgYmxvY2sgZHJpdmVycyBhcmUgYnVpbHQtaW4uIFNvIHdlIHdvdWxkIGJlIHRyYWRpbmcgb25l IGhhY2sKZm9yIGFub3RoZXIuCgpNaWNoYWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK