From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] IB/ucma: check workqueue allocation before usage Date: Thu, 01 Oct 2015 10:54:23 -0400 Message-ID: <560D491F.7020200@oracle.com> References: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> <20150917225934.GA22326@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150917225934.GA22326-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe , Yishai Hadas Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 09/17/2015 06:59 PM, Jason Gunthorpe wrote: > On Thu, Sep 17, 2015 at 04:04:19PM -0400, Sasha Levin wrote: >> Allocating a workqueue might fail, which wasn't checked so far and would >> lead to NULL ptr derefs when an attempt to use it was made. > > Indeed. > > Yishai, please check this and check the other patches you've sent to > see if they have a similar error. Ping? It doesn't seem that the patch got anywhere. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756489AbbJAOyi (ORCPT ); Thu, 1 Oct 2015 10:54:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26970 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbbJAOyg (ORCPT ); Thu, 1 Oct 2015 10:54:36 -0400 Message-ID: <560D491F.7020200@oracle.com> Date: Thu, 01 Oct 2015 10:54:23 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jason Gunthorpe , Yishai Hadas CC: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/ucma: check workqueue allocation before usage References: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> <20150917225934.GA22326@obsidianresearch.com> In-Reply-To: <20150917225934.GA22326@obsidianresearch.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2015 06:59 PM, Jason Gunthorpe wrote: > On Thu, Sep 17, 2015 at 04:04:19PM -0400, Sasha Levin wrote: >> Allocating a workqueue might fail, which wasn't checked so far and would >> lead to NULL ptr derefs when an attempt to use it was made. > > Indeed. > > Yishai, please check this and check the other patches you've sent to > see if they have a similar error. Ping? It doesn't seem that the patch got anywhere. Thanks, Sasha