From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754350AbbJAPGM (ORCPT ); Thu, 1 Oct 2015 11:06:12 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34831 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbbJAPGK (ORCPT ); Thu, 1 Oct 2015 11:06:10 -0400 Subject: Re: [RFC PATCH 0/3] net: dsa: Complete and fix the dsa unbinding To: Florian Fainelli , "David S. Miller" , Jesper Dangaard Brouer References: <560B9B70.6030202@baylibre.com> <560C1F5A.5070506@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux@roeck-us.net From: Neil Armstrong Organization: Baylibre Message-ID: <560D4BDE.3080400@baylibre.com> Date: Thu, 1 Oct 2015 17:06:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <560C1F5A.5070506@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2015 07:43 PM, Florian Fainelli wrote: > On 30/09/15 01:21, Neil Armstrong wrote: >> In order to cleanly unbind the dsa core, either as a module removal, >> or a platform device unbind, switch the allocation the their devm_ >> counterparts and complete the destroy functions. >> >> The last patch is an experimental way to exit the probe when no >> switch is found in the discover process. >> >> The patches are based on the current net-next. > > I looked at the patches and they bring DSA in a better direction. For > future submissions, could you CC people who recently worked on DSA, like > Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically > give your patches a try fairly quickly. > > In case you are seriously considering making DSA a loadable module, > there were an earlier attempt here: > > http://comments.gmane.org/gmane.linux.network/345803 > > Thanks! > >> >> Neil Armstrong (3): >> net: dsa: Use devm_ prefixed allocations >> net: dsa: complete dsa_switch_destroy calls >> net: dsa: exit probe if no switch were found >> >> net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++------- >> 1 file changed, 60 insertions(+), 7 deletions(-) >> > > Hi All, Thanks for the tests and reviews. My first intent is to make dynamic unbind/bind reliable, the reliable loadable module support is a more complex target, but starting with unbind is a simpler start. Should I re-post with the missing people, the Tested-by & without the RFC tag ? Regards, Neil