From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com
Subject: Re: [PATCH v4 0/3] crypto: akcipher - Changes to asymmetric key API
Date: Thu, 1 Oct 2015 21:09:54 -0700 [thread overview]
Message-ID: <560E0392.4020005@intel.com> (raw)
In-Reply-To: <20151002040409.GA557@gondor.apana.org.au>
On 10/01/2015 09:04 PM, Herbert Xu wrote:
>> I do use src_len for processing. The sg_len() is still useful for
>> > parameter checking to make sure that src_len <= sg_len(req->src)
> I don't see the point. We don't check that anywhere else in the
> crypto API. It's the caller's responsibility to provide valid input
> parameters.
>
> Untrusted callers must be vetted at the point of entry, i.e.,
> algif.
This is used not only in rsa, but also in the new mpi sgl helpers.
Should I drop all the params checking?
next prev parent reply other threads:[~2015-10-02 4:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 20:28 [PATCH v4 0/3] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-10-01 20:28 ` [PATCH v4 1/3] lib/scatterlist: Add sg_len helper Tadeusz Struk
2015-10-01 20:28 ` [PATCH v4 2/3] lib/mpi: Add mpi sgl helpers Tadeusz Struk
2015-10-01 20:29 ` [PATCH v4 3/3] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-10-02 3:20 ` [PATCH v4 0/3] " Herbert Xu
2015-10-02 3:40 ` Tadeusz Struk
2015-10-02 4:04 ` Herbert Xu
2015-10-02 4:09 ` Tadeusz Struk [this message]
2015-10-02 4:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E0392.4020005@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.