From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 4/5] libxc: split p2m allocation in domain builder from other magic pages Date: Fri, 2 Oct 2015 11:14:04 +0200 Message-ID: <560E4ADC.4090804@suse.com> References: <1441974742-27352-1-git-send-email-jgross@suse.com> <1441974742-27352-5-git-send-email-jgross@suse.com> <1443703638.11707.37.camel@citrix.com> <560E0043.1070306@suse.com> <1443776678.11707.51.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1443776678.11707.51.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xensource.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 10/02/2015 11:04 AM, Ian Campbell wrote: > On Fri, 2015-10-02 at 05:55 +0200, Juergen Gross wrote: >> On 10/01/2015 02:47 PM, Ian Campbell wrote: >>> On Fri, 2015-09-11 at 14:32 +0200, Juergen Gross wrote: >>>> Add an own function to allocate the p2m list in the domain builder in >>> >>> I'm not sure what you mean by "own" here. Perhaps "hook" or "callback"? >> >> Before the p2m list allocation was done in the alloc_magic_pages hook. >> I'm just splitting this function. > > I get that, but "own" is not the right word for this. Obviously. > Perhaps you meant "separate (hook|function)" or "specific (hook|function)" > or something like that? > > Perhaps something like: > > Refactor allocation of the p2m list out of alloc_magic_pages into a new > alloc_p2m_list hook. In v2 I've changed the wording in a similar way. Juergen