From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZhwUw-0004oL-Qe
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 05:19:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZhwUs-0006nj-Th
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 05:19:26 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:6341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZhwUs-0006nX-MC
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 05:19:22 -0400
References: <1443697130-21431-1-git-send-email-james.hogan@imgtec.com>
	<1443697130-21431-3-git-send-email-james.hogan@imgtec.com>
From: Leon Alrae <leon.alrae@imgtec.com>
Message-ID: <560E4C0F.2000304@imgtec.com>
Date: Fri, 2 Oct 2015 10:19:11 +0100
MIME-Version: 1.0
In-Reply-To: <1443697130-21431-3-git-send-email-james.hogan@imgtec.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/6] disas/mips: Add R6 jr/jr.hb to
	disassembler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On 01/10/15 11:58, James Hogan wrote:
> @@ -2420,9 +2420,11 @@ const struct mips_opcode mips_builtin_opcodes[] =
>  {"hibernate","",        0x42000023, 0xffffffff,	0, 			0,		V1	},
>  {"ins",     "t,r,+A,+B", 0x7c000004, 0xfc00003f, WR_t|RD_s,    		0,		I33	},
>  {"jr",      "s",	0x00000008, 0xfc1fffff,	UBD|RD_s,		0,		I1	},
> +{"jr",      "s",	0x00000009, 0xfc1fffff,	UBD|RD_s,		0,		I32R6	}, /* jalr */
>  /* jr.hb is officially MIPS{32,64}R2, but it works on R1 as jr with
>     the same hazard barrier effect.  */
>  {"jr.hb",   "s",	0x00000408, 0xfc1fffff,	UBD|RD_s,		0,		I32	},
> +{"jr.hb",   "s",	0x00000408, 0xfc1fffff,	UBD|RD_s,		0,		I32R6	}, /* jalr.hb */

jr.hb match should be 0x00000409, otherwise:

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>