From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Date: Fri, 2 Oct 2015 11:45:18 +0100 Message-ID: <560E603E.8080603@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-2-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:39769 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbbJBKpW (ORCPT ); Fri, 2 Oct 2015 06:45:22 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Linus Walleij Cc: Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "Rafael J. Wysocki" , Alessandro Zummo , Alexandre Belloni , "rtc-linux@googlegroups.com" On 02/10/15 11:40, Linus Walleij wrote: > On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > >> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >> be left enabled so as to allow them to work as expected during the >> suspend-resume cycle, but doesn't guarantee that it will wake the system >> from a suspended state, enable_irq_wake is recommended to be used for >> the wakeup. >> >> This patch removes the use of IRQF_NO_SUSPEND flags and uses newly >> introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. >> >> Cc: Linus Walleij >> Cc: Alessandro Zummo >> Cc: Alexandre Belloni >> Cc: rtc-linux@googlegroups.com >> Signed-off-by: Sudeep Holla > > Looks correct to me. > Acked-by: Linus Walleij > Thanks, while you are at it, do you know what interrupt stv2_pl031 shares so that I can fix the TODO in the comment or the code(whichever applicable). Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by gmr-mx.google.com with ESMTP id el2si1575624pbb.0.2015.10.02.03.45.22 for ; Fri, 02 Oct 2015 03:45:22 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag To: Linus Walleij References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-2-git-send-email-sudeep.holla@arm.com> Cc: Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "Rafael J. Wysocki" , Alessandro Zummo , Alexandre Belloni , "rtc-linux@googlegroups.com" From: Sudeep Holla Message-ID: <560E603E.8080603@arm.com> Date: Fri, 2 Oct 2015 11:45:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 02/10/15 11:40, Linus Walleij wrote: > On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > >> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >> be left enabled so as to allow them to work as expected during the >> suspend-resume cycle, but doesn't guarantee that it will wake the system >> from a suspended state, enable_irq_wake is recommended to be used for >> the wakeup. >> >> This patch removes the use of IRQF_NO_SUSPEND flags and uses newly >> introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. >> >> Cc: Linus Walleij >> Cc: Alessandro Zummo >> Cc: Alexandre Belloni >> Cc: rtc-linux@googlegroups.com >> Signed-off-by: Sudeep Holla > > Looks correct to me. > Acked-by: Linus Walleij > Thanks, while you are at it, do you know what interrupt stv2_pl031 shares so that I can fix the TODO in the comment or the code(whichever applicable). Regards, Sudeep -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.