From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH v5 03/34] cxlflash: Fix read capacity timeout Date: Fri, 2 Oct 2015 14:49:04 +0200 Message-ID: <560E7D40.2060508@redhat.com> References: <1443714773-9176-1-git-send-email-mrochs@linux.vnet.ibm.com> <1443714897-11795-1-git-send-email-mrochs@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1443714897-11795-1-git-send-email-mrochs@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight Cc: Manoj Kumar , Michael Neuling , "Manoj N. Kumar" , linuxppc-dev@lists.ozlabs.org List-Id: linux-scsi@vger.kernel.org T24gMS4xMC4yMDE1IDE3OjU0LCBNYXR0aGV3IFIuIE9jaHMgd3JvdGU6Cj4gRnJvbTogTWFub2og S3VtYXIgPGt1bWFybW5AdXMuaWJtLmNvbT4KPgo+IFRoZSB0aW1lb3V0IHZhbHVlIGZvciByZWFk IGNhcGFjaXR5IGlzIHRvbyBzbWFsbC4gQ2VydGFpbiBkZXZpY2VzCj4gbWF5IHRha2UgbG9uZ2Vy IHRvIHJlc3BvbmQgYW5kIHRodXMgdGhlIGNvbW1hbmQgbWF5IHByZW1hdHVyZWx5Cj4gdGltZW91 dC4gQWRkaXRpb25hbGx5IHRoZSBsaXRlcmFsIHVzZWQgZm9yIHRoZSB0aW1lb3V0IGlzIHN0YWxl Lgo+Cj4gVXBkYXRlIHRoZSB0aW1lb3V0IHRvIDMwIHNlY29uZHMgKG1hdGNoZXMgdGhlIHZhbHVl IHVzZWQgaW4gc2QuYykKPiBhbmQgcmV3b3JrIHRoZSB0aW1lb3V0IGxpdGVyYWwgdG8gYSBtb3Jl IGFwcHJvcHJpYXRlIGRlc2NyaXB0aW9uLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dGhldyBSLiBP Y2hzIDxtcm9jaHNAbGludXgudm5ldC5pYm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hbm9qIE4u IEt1bWFyIDxtYW5vakBsaW51eC52bmV0LmlibS5jb20+Cj4gUmV2aWV3ZWQtYnk6IEJyaWFuIEtp bmcgPGJya2luZ0BsaW51eC52bmV0LmlibS5jb20+CgpSZXZpZXdlZC1ieTogVG9tYXMgSGVuemwg PHRoZW56bEByZWRoYXQuY29tPgoKVG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2 QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4 cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 24E7D1A04D3 for ; Fri, 2 Oct 2015 22:49:10 +1000 (AEST) Subject: Re: [PATCH v5 03/34] cxlflash: Fix read capacity timeout To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight References: <1443714773-9176-1-git-send-email-mrochs@linux.vnet.ibm.com> <1443714897-11795-1-git-send-email-mrochs@linux.vnet.ibm.com> Cc: Michael Neuling , linuxppc-dev@lists.ozlabs.org, Manoj Kumar , "Manoj N. Kumar" From: Tomas Henzl Message-ID: <560E7D40.2060508@redhat.com> Date: Fri, 2 Oct 2015 14:49:04 +0200 MIME-Version: 1.0 In-Reply-To: <1443714897-11795-1-git-send-email-mrochs@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1.10.2015 17:54, Matthew R. Ochs wrote: > From: Manoj Kumar > > The timeout value for read capacity is too small. Certain devices > may take longer to respond and thus the command may prematurely > timeout. Additionally the literal used for the timeout is stale. > > Update the timeout to 30 seconds (matches the value used in sd.c) > and rework the timeout literal to a more appropriate description. > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Reviewed-by: Brian King Reviewed-by: Tomas Henzl Tomas