From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH v5 05/34] cxlflash: Fix data corruption when vLUN used over multiple cards Date: Fri, 2 Oct 2015 15:03:54 +0200 Message-ID: <560E80BA.90906@redhat.com> References: <1443714773-9176-1-git-send-email-mrochs@linux.vnet.ibm.com> <1443714908-13176-1-git-send-email-mrochs@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1443714908-13176-1-git-send-email-mrochs@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight Cc: Michael Neuling , "Manoj N. Kumar" , linuxppc-dev@lists.ozlabs.org List-Id: linux-scsi@vger.kernel.org T24gMS4xMC4yMDE1IDE3OjU1LCBNYXR0aGV3IFIuIE9jaHMgd3JvdGU6Cj4gSWYgdGhlIHNhbWUg dmlydHVhbCBMVU4gaXMgYWNjZXNzZWQgb3ZlciBtdWx0aXBsZSBjYXJkcywgb25seSBhY2Nlc3Nl cwo+IG1hZGUgb3ZlciB0aGUgZmlyc3QgY2FyZCB3aWxsIGJlIHZhbGlkLiBBY2Nlc3NlcyBtYWRl IG92ZXIgdGhlIHNlY29uZAo+IGNhcmQgd2lsbCBnbyB0byB0aGUgd3JvbmcgTFVOIGNhdXNpbmcg ZGF0YSBjb3JydXB0aW9uLgo+Cj4gVGhpcyBpcyBiZWNhdXNlIHRoZSBnbG9iYWwgTFVOJ3MgbW9k ZSB3b3JkIHdhcyBiZWluZyB1c2VkIHRvIGRldGVybWluZQo+IHdoZXRoZXIgdGhlIExVTiB0YWJs ZSBmb3IgdGhhdCBjYXJkIG5lZWRzIHRvIGJlIHByb2dyYW1tZWQuIFRoZSBtb2RlCj4gd29yZCB3 b3VsZCBiZSBzZXR1cCBieSB0aGUgZmlyc3QgY2FyZCwgY2F1c2luZyB0aGUgTFVOIHRhYmxlIGZv ciB0aGUKPiBzZWNvbmQgY2FyZCB0byBub3QgYmUgcHJvZ3JhbW1lZC4KPgo+IEJ5IHVuY29uZGl0 aW9uYWxseSBpbml0aWFsaXppbmcgdGhlIExVTiB0YWJsZSAobm90IGRlcGVuZGluZyBvbiB0aGUK PiBtb2RlIHdvcmQpLCB0aGUgcHJvYmxlbSBpcyBhdm9pZGVkLgo+Cj4gU2lnbmVkLW9mZi1ieTog TWF0dGhldyBSLiBPY2hzIDxtcm9jaHNAbGludXgudm5ldC5pYm0uY29tPgo+IFNpZ25lZC1vZmYt Ynk6IE1hbm9qIE4uIEt1bWFyIDxtYW5vakBsaW51eC52bmV0LmlibS5jb20+Cj4gUmV2aWV3ZWQt Ynk6IEJyaWFuIEtpbmcgPGJya2luZ0BsaW51eC52bmV0LmlibS5jb20+CgpSZXZpZXdlZC1ieTog VG9tYXMgSGVuemwgPHRoZW56bEByZWRoYXQuY29tPgoKVG9tYXMKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QK TGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xp c3RpbmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9AAC81A04D3 for ; Fri, 2 Oct 2015 23:04:00 +1000 (AEST) Subject: Re: [PATCH v5 05/34] cxlflash: Fix data corruption when vLUN used over multiple cards To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight References: <1443714773-9176-1-git-send-email-mrochs@linux.vnet.ibm.com> <1443714908-13176-1-git-send-email-mrochs@linux.vnet.ibm.com> Cc: Michael Neuling , linuxppc-dev@lists.ozlabs.org, "Manoj N. Kumar" From: Tomas Henzl Message-ID: <560E80BA.90906@redhat.com> Date: Fri, 2 Oct 2015 15:03:54 +0200 MIME-Version: 1.0 In-Reply-To: <1443714908-13176-1-git-send-email-mrochs@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1.10.2015 17:55, Matthew R. Ochs wrote: > If the same virtual LUN is accessed over multiple cards, only accesses > made over the first card will be valid. Accesses made over the second > card will go to the wrong LUN causing data corruption. > > This is because the global LUN's mode word was being used to determine > whether the LUN table for that card needs to be programmed. The mode > word would be setup by the first card, causing the LUN table for the > second card to not be programmed. > > By unconditionally initializing the LUN table (not depending on the > mode word), the problem is avoided. > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Reviewed-by: Brian King Reviewed-by: Tomas Henzl Tomas