From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] bpf: fix panic in SO_GET_FILTER with native ebpf programs
Date: Fri, 2 Oct 2015 08:04:03 -0700 [thread overview]
Message-ID: <560E9CE3.1010302@plumgrid.com> (raw)
In-Reply-To: <98ab6d68ec6db39bfa3b1655d228692457861d60.1443779830.git.daniel@iogearbox.net>
On 10/2/15 3:06 AM, Daniel Borkmann wrote:
> However, sk_get_filter() wasn't updated to test for this at the
> time when eBPF could be attached. Just throw an error to the user
> to indicate that eBPF cannot be dumped over this interface.
> That way, it can also be known that a program_is_ attached (as
> opposed to just return 0), and a different (future) method needs
> to be consulted for a dump.
>
> Fixes: 89aa075832b0 ("net: sock: allow eBPF programs to be attached to sockets")
> Signed-off-by: Daniel Borkmann<daniel@iogearbox.net>
ouch. Thanks for the fix!
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-10-02 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 10:06 [PATCH net] bpf: fix panic in SO_GET_FILTER with native ebpf programs Daniel Borkmann
2015-10-02 15:04 ` Alexei Starovoitov [this message]
2015-10-05 13:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E9CE3.1010302@plumgrid.com \
--to=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.