From: Daniel Borkmann <daniel@iogearbox.net>
To: Tycho Andersen <tycho.andersen@canonical.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@amacapital.net>,
Alexei Starovoitov <ast@plumgrid.com>
Subject: Re: [PATCH net-next] bpf, seccomp: prepare for upcoming criu support
Date: Fri, 02 Oct 2015 17:17:26 +0200 [thread overview]
Message-ID: <560EA006.2000306@iogearbox.net> (raw)
In-Reply-To: <20151002150603.GM23065@smitten>
On 10/02/2015 05:06 PM, Tycho Andersen wrote:
...
>> Cc: Pavel Emelyanov <xemul@parallels.com>
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: Andy Lutomirski <luto@amacapital.net>
>> Cc: Alexei Starovoitov <ast@plumgrid.com>
>> ---
>> This is in realtion to Tycho's latest patch set under [1]. The BPF
>> handling is unfortunately not correct (triggering a crash on kernels
>> that can set pages as ro).
>>
>> This patch here provides a minimal, simple interface from BPF API side
>> as a possible step forward, so that the focus can then be on seccomp
>> side wrt criu. F.e., dumping could happen similarly as in Pavel's
>> sk_get_filter().
>>
>> I have tested/based this against net-next, but have no issues whether
>> Kees wants to take it, or whether it should go through both trees to
>> reduce merge issues as once the case with 0fc174dea545 ("ebpf: make
>> internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs").
>
> I'll send out a revised version of my set with Andy's comments later
> today and not include this patch. Let me know if I should do something
> differently.
Should be okay.
Please make sure to describe in your cover letter that your series builds
on top of ...
http://patchwork.ozlabs.org/patch/525492/
... so that whoever takes the set eventually is aware of this.
Thanks again,
Daniel
next prev parent reply other threads:[~2015-10-02 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 13:17 [PATCH net-next] bpf, seccomp: prepare for upcoming criu support Daniel Borkmann
2015-10-02 15:06 ` Tycho Andersen
2015-10-02 15:17 ` Daniel Borkmann [this message]
2015-10-02 15:09 ` Alexei Starovoitov
2015-10-02 15:21 ` Daniel Borkmann
2015-10-05 13:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560EA006.2000306@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=tycho.andersen@canonical.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.