From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
kbuild test robot <lkp@intel.com>,
ffado-devel@lists.sf.net, kbuild-all@01.org
Subject: Re: [PATCH 1/7] ALSA: firewire-tascam: add skeleton for TASCAM FireWire series
Date: Sat, 3 Oct 2015 11:14:22 +0200 [thread overview]
Message-ID: <560F9C6E.70800@ladisch.de> (raw)
In-Reply-To: <560F3EB0.7020508@sakamocchi.jp>
Takashi Sakamoto wrote:
>>>> 23 data = be32_to_cpu(fw_dev->config_rom[28]);
>
> About using 'be32_to_cpu()', the 'config_rom' member actually has 'const
> u32 *', while in the member caracters in the textual leaf are aligned in
> big-endian.
Strictly speaking, strings do not have an endianness.
Most data in the actual configuration ROM is organized as big-endian 32-
bit values, so the FireWire core converts _all_ words from big endian to
CPU endian. The words that are not actually 32-bit values but strings
have to be converted back; the correct function for this is cpu_to_be32().
Regards,
Clemens
next prev parent reply other threads:[~2015-10-03 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 13:02 [PATCH 0/7 v3] firewire-tascam: new driver for TASCAM FireWire series Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 1/7] ALSA: firewire-tascam: add skeleton " Takashi Sakamoto
2015-10-01 13:54 ` kbuild test robot
2015-10-02 16:24 ` Takashi Iwai
2015-10-02 18:47 ` Clemens Ladisch
2015-10-03 2:34 ` Takashi Sakamoto
2015-10-03 8:51 ` Takashi Iwai
2015-10-03 10:33 ` Stefan Richter
2015-10-03 9:14 ` Clemens Ladisch [this message]
2015-10-03 9:57 ` Takashi Sakamoto
2015-10-03 10:54 ` Stefan Richter
2015-10-04 11:54 ` Takashi Sakamoto
2015-10-03 16:07 ` Takashi Iwai
2015-10-03 23:33 ` Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 2/7] ALSA: firewire-tascam: add a structure for model-dependent parameters Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 3/7] ALSA: firewire-tascam: add proc node to show firmware information Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 4/7] ALSA: firewire-tascam: add data block processing layer Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 5/7] ALSA: firewire-tascam: add streaming functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 6/7] ALSA: firewire-tascam: add PCM functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 7/7] ALSA: firewire-tascam: add hwdep interface Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560F9C6E.70800@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sf.net \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
--cc=o-takashi@sakamocchi.jp \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.