All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] kodi: Without native RPC use libtirpc
Date: Sat, 3 Oct 2015 19:25:57 +0100	[thread overview]
Message-ID: <56101DB5.3010506@mind.be> (raw)
In-Reply-To: <1443890749-27092-4-git-send-email-maxime.hadjinlian@gmail.com>

On 03-10-15 17:45, Maxime Hadjinlian wrote:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 But...

> ---
>  package/kodi/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 797f59d..e87bb32 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -181,13 +181,14 @@ config BR2_PACKAGE_KODI_LIBMICROHTTPD
>  
>  config BR2_PACKAGE_KODI_LIBNFS
>  	bool "nfs"
> -	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
> +	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc

 I would have split this long line. And perhaps the comment should be
libnfs -> libtirpc


 Regards,
 Arnout


> +	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_PACKAGE_LIBNFS
>  	help
>  	  Enable NFS server support.
>  
> -comment "nfs support needs a toolchain w/ RPC support"
> -	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
> +comment "nfs support needs a toolchain w/ threads support"
> +	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
>  
>  config BR2_PACKAGE_KODI_RTMPDUMP
>  	bool "rtmp"
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-10-03 18:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03 16:45 [Buildroot] [PATCH 1/4] toolchain-external: Remove BLACKFIN_UCLINUX_2012R2 Maxime Hadjinlian
2015-10-03 16:45 ` [Buildroot] [PATCH 2/4] blackfin: 2012R2 toolchain is gone, remove kludges Maxime Hadjinlian
2015-10-03 18:21   ` Arnout Vandecappelle
2015-10-03 16:45 ` [Buildroot] [PATCH 3/4] libnfs: Without native RPC use libtirpc Maxime Hadjinlian
2015-10-03 18:22   ` Arnout Vandecappelle
2015-10-03 16:45 ` [Buildroot] [PATCH 4/4] kodi: " Maxime Hadjinlian
2015-10-03 18:25   ` Arnout Vandecappelle [this message]
2015-10-03 18:13 ` [Buildroot] [PATCH 1/4] toolchain-external: Remove BLACKFIN_UCLINUX_2012R2 Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56101DB5.3010506@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.