From: Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading
Date: Sat, 3 Oct 2015 22:41:59 +0200 [thread overview]
Message-ID: <56103D97.60906@gmail.com> (raw)
Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d
(allow arbitrary OF matching for "jedec,spi-nor") broke autoloading
of the m25p80 module.
MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias
prevents module autoloading.
Of course we could revert the removal of the "spi-nor" device alias.
However it might be better to switch to DT-based matching for
DT-configured devices.
Adding a call to of_device_uevent_modalias to spi_uevent in spi.c
solved the issue for me, drawback however is that just the first
"compatible" value is used as modalias. In case of m25p80 this means
that "jedec,spi-nor" has to be the first "compatible" value.
This constraint might be too strict ..
Having said that I'm not sure what could be a better way to fix
the issue than just re-introducing the "spi-nor" device alias.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-10-03 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 20:41 Heiner Kallweit [this message]
[not found] ` <56103D97.60906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-03 21:35 ` m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2015-10-03 21:54 Heiner Kallweit
2015-11-12 18:59 ` m25p80: Commit "allow arbitrary OF matching for "jedec, spi-nor"" " Brian Norris
2015-11-12 18:59 ` m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" " Brian Norris
2015-11-12 18:59 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56103D97.60906@gmail.com \
--to=hkallweit1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.