From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH] staging: rdma: Fix braces around if/else Date: Sun, 4 Oct 2015 09:47:52 +0300 Message-ID: <5610CB98.1090907@mellanox.com> References: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Marciniszyn , Doug Ledford , Martin Kletzander , Sean Hefty , Hal Rosenstock List-Id: linux-rdma@vger.kernel.org On 10/3/2015 11:55 PM, Martin Kletzander wrote: > Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug) don't want to spend time on fixing such drivers, right? Or. > > Signed-off-by: Martin Kletzander > --- > There is one warning reported in this patch though. That's because of > the multiline string and it's pre-existing. Feel free to let me know > if that should be fixed too, I'd also remove the pointless '#' then. > On the other hand, it'll create more-than-80-columns long line. > > drivers/staging/rdma/ipath/ipath_driver.c | 19 ++++++++----------- > drivers/staging/rdma/ipath/ipath_file_ops.c | 12 ++++++------ > drivers/staging/rdma/ipath/ipath_iba6110.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++----- > drivers/staging/rdma/ipath/ipath_intr.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_sysfs.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_verbs.c | 4 ++-- > 7 files changed, 30 insertions(+), 36 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751296AbbJDHDl (ORCPT ); Sun, 4 Oct 2015 03:03:41 -0400 Received: from mail-db3on0086.outbound.protection.outlook.com ([157.55.234.86]:15863 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751199AbbJDHDk (ORCPT ); Sun, 4 Oct 2015 03:03:40 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH] staging: rdma: Fix braces around if/else To: Greg Kroah-Hartman References: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> CC: Martin Kletzander , , Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , , From: Or Gerlitz Message-ID: <5610CB98.1090907@mellanox.com> Date: Sun, 4 Oct 2015 09:47:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.129.120] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD025;1:NAy4ZSuqg+vTUR/cnFpoKI/GOITWzKLvhDUk0zqjbwZ1aruzY20B/jpsTkeLeHXDoNAhRLIDiRjImyMQkuvKs2Yf1c8ynA/mKnvdST6eRAUtun9CfmN1FSo4uxRR931WNx0prgh+2JjhOwR4mpt553Qo05klN3DVtp8lMeNTeipy1Cl6G4S6TC6Qk+g/gdwIu/UoBj4qKXSUQeSG9mXJsOH2ZR3ym8bJnl5qIMSZfDdrWfpPwE33F/DYAkDft477Yn/SqvuWP4Jh+nwkwFEux504dNvFjr0coO8/Kj6pK4dmh/j15d81OZJZnH0mw1wHisJsbQiw6w2NUSXqP9YHWpJ+pAQQOtaE0FpNkAcOOWnGXMLxnpWaOoMOXbh3Rab3g2ZKHjEIDTsFu4aiB43ukQ== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377454003)(24454002)(52044002)(479174004)(189002)(199003)(50986999)(110136002)(47776003)(97736004)(87266999)(5001860100001)(65956001)(2950100001)(19580405001)(5008740100001)(64126003)(65816999)(106466001)(5001830100001)(65806001)(54356999)(4001540100001)(77096005)(86362001)(68736005)(64706001)(76176999)(4001350100001)(23746002)(50466002)(87936001)(19580395003)(11100500001)(80316001)(46102003)(62966003)(6806005)(5007970100001)(189998001)(92566002)(33656002)(5004730100002)(36756003)(83506001)(59896002)(77156002)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR05MB361;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB361;2:F2gVahyc4oUxts0DVu5QJwdi1J8jaClFaeE1JpFjIitVMKpppFFz30arkP1syp/aGg6w90d8VIdgWMY4agtSC1UeFq/tJrkT2/W5HBioZ01EZvdhTlIsHBZEPYsPs4dqehh6KF3JmXB/A9Osn0N4VdAldkrDWUqTKNrLjJPetZ4=;3:PXOnihsJwj4PPqeu4HpMhYrahjrPCykYmYGRqUZyxUgMxmIEdoBx+rEt4rjfa80n0oZMVOwaFfppOBhK7dPV66VEdvBObN7MnPn9pi54+I8aQcgLcGUfsx2RuhJHDnVM6xVBMzOkl1LwOVjOi+/niQCrMSDq0pcQs68vfQM6nGcD3CyvYITaGSnGGE8N1FE+bAC2i9gsxtKolLlqy8bKuDIAO82KiL78+zSQK9BV7+Us3qWq/956CKpnznozcuaOCr6t3xvLpJQqSD8HBHBDUg==;25:KzCe1JNMgsfI/cyU6aqr4U2sFvkRZp+TBO12Cnr/9auz35ph7cGrm33it5vujpuazjftzILvZ7dav+T4BqDYkvLyETG5L+5HwoiNYcO0lob8AH+ssx6gQ0zvyq2ehYicAKw3KY9qgwPQ56Gwps/Xa68LcHVP/oa1BEfqkY8O7XmXKZDdApt4uHlJ1AyWyGstI6tk97/mbaT5TtRhWbto1zwSw7+BK5eBwYp5puLjdEHHvc139a1gLPnKgwT9fW3Q X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB3PR05MB361; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB361;20:L4ukIO9srK0QHIP1/JJgTbkGffMTeupw+NvpTnYfsv33xdaE8LUXam2WHrDRmBaBSXDg0YsMR0DkyatBB9AXmflDrhHra8Dvx4JBUded3UdU/pTdlbh6IPfxfMO2lb8CsWvKUnO0ta73P7DHK6DNuylx5Tt+CG2j9+NC0N79c1hGPNHiq5fmt8EpP9aaRZ+Foiu82/hc4guIFT0EUY3QX79dEQmoF2XUEPXw+fcBW4Q2/93thibHhPtt+vOhVvOTTFLPdiS+lv3EQwSpM02Im3Qg539Ta7eFP/MkLpcKI4sBZoJLzuGyDO+WSX545rjdLzqSOp6fsQjGLxy9e45m/TrCfi7ETw9nlcfY44vt73MqVt9WdOzV5UJJ2s3qt4pl9OesKJiwOsQxh2Oc0ZfN38PDW1dEPuodryS+0SjAWulB0GsHpjHqcmolBv5LiFOk2LvOF/tNPVtcokXrRihnNnslqQeUcAtmAVPKSk84xAFn26z/c6JOc3zMSUwWLB5z;4:Nx5rNBX5/m7Cz6d9FuzJhjACssF5BREfX66d1Fsb7rJMmA+sPQISro6ldRSPDM3duq1farMfCl7CcnWoVep/JYGoor5wMrUr0untclcgKyJisW2miRvV1rzTdST3eIqkFGuJBloabWOpDaUWO8oPsfD7fv91WybmeJhTWXmx98XldY8J/K4OmisBKCdVlXnpneo1ixu8LPlnUfZh0WxzV4Ta8Wt1HzL3UTNlT56IVTc5OQMyRcJV85r9z9aVVWaDETwk09B8uMWgzHgZlT0Q32c1yWlWvVTdgKHMYkoIl3omKxnszOtpczH+I2E7C9GyT+CbVUiZp+YilZccSdORqglzVpo0Dy40z8OYbk6d0rs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:DB3PR05MB361;BCL:0;PCL:0;RULEID:;SRVR:DB3PR05MB361; X-Forefront-PRVS: 0719EC6A9A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB3PR05MB361;23:5gf6pli/VbB+Iz63niqpYAOpJU/VKmpbE6vZ93?= =?Windows-1252?Q?xFrXNUupPWWN9TNlMPX5kNUy1oxXpQToz0bf3a/OJmxrpjsYBkTs3bAa?= =?Windows-1252?Q?GgiDUEv6NvNXDLV7asONo5NAv44Ir22b+SJ6k3C+g2+9JCJB4cAHTipl?= =?Windows-1252?Q?z1sC9g/tOZO0KpFpHOoYmwVgvpcjMUvi8R74afWPfGcCkZeIbuwaHLNq?= =?Windows-1252?Q?PSJZbhwAjd2hAwhfVIpFd6P2Hgpvl9XhC+iUBTzT1lSSIc63J9oGP8MV?= =?Windows-1252?Q?AL0HNuDa2uZHrSxD3utaQZ4vVrhqAWfZnO9m7RmFlE5Av29yVifTz9OA?= =?Windows-1252?Q?0rhDC/4kSPCegM7xMq9TvC+BMNeKHYFkXmqIE0OzvPb+oYyKtmLl+s0P?= =?Windows-1252?Q?tk0GT2l2gzui0kvvI4o0DYdLn8Vbef5mgXX6vqWu7W7wB/be7oPr+CgL?= =?Windows-1252?Q?vt0kEeKUyQCSs6rr70sV88Nbzb1iMMg/Mv9N5m9rBzqEKZ2eB+9J4s4N?= =?Windows-1252?Q?lazaV+wJt7iPAjpEOQsnio1gIn1sA7C3sIuf30ZbjJFxMV9H+p9byx/J?= =?Windows-1252?Q?wn84AwUYyoybbKB7XlGs1Nynz21YpWf5mbagZbqxojZ21VpNCpidIWqh?= =?Windows-1252?Q?0QEjPovzdAL10X6r/ySReAZBfmAnNMWr1SdB+KCV+cY9tcJk4tcMXDBR?= =?Windows-1252?Q?cV2FyxdjoU7cksBf8kvpbnGvuixZoRlahqkSdYl8hT0HSYO2uW/e59JD?= =?Windows-1252?Q?3cvk6Q1f2mjej7IFDlmHXrOl6rDDMId6MPVPCU9Ph5lViX/MvV/7BDpz?= =?Windows-1252?Q?1XE10I31rCvu6JjE5eizN0OUjOY3RX0DnTWx29YUI5QWjGPFE7Tfit1w?= =?Windows-1252?Q?kAcdqUZc8YqJSiVAY2a/AY8sN3WgKNaDIQ5rxR4whEnjKKet8KARl4QR?= =?Windows-1252?Q?wy9bOn1hgtOZ6aQ6oufOgtxDNgXMQAi5CgKAj3YdhirnsiAPq7q7MPRE?= =?Windows-1252?Q?ZdvBnupZhFnDj9R/Lv+id4Y1G7Le0/6DA1zzVEdhIk4oEaAmtslH0diY?= =?Windows-1252?Q?/8WAaUiRbK+A+W6Y1W1bJOwlUdR1lQCOIhq7qIFyokR6NpTRvVk8qiku?= =?Windows-1252?Q?Sj1EA/sCEslcieVNRMTqHLzy9EwFw8KFxi4bnRsl52X8wFVa4Kx6jWoF?= =?Windows-1252?Q?tE1pUXdHl8VWTMzI9DJaqEbSfHUusKLQW+cs+49eDohZons6OAT/urfO?= =?Windows-1252?Q?ySBZYxMKIJwPdLlaXu4r/oojC2luIERVw83YWWgzgPK/2JdXq4/lVU9h?= =?Windows-1252?Q?palWKLrxNoKDOI35meGywETYU1m+yfNqrEcFWffhA5UE4OmWqm1DQQU8?= =?Windows-1252?Q?/55PhsQ56Cb1lNQGQDSCArhli75xk51l8sXIaExcmO7yjSZ2azde14EE?= =?Windows-1252?Q?kvuuDG3wIKWLJh+9UeYLfRDbNZFed1+mk+kUQW2Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB361;5:wFXgwVhWilGwQweRRm4tv3K7Lhn5BKO8YQDllaims7KNNhfyHYQTmIn8zNkSpmxUW1FRuvEW09fm8MT3SK+O42bMaJ7Mhcc/4C31xnMLTIGJRGdeSOOIFnV+9NnaaH8fyvUCHZER99KymNiGktw4ZA==;24:mdsdZMdfGCgFFI4kuY4hg5kmPJR2+pb/SFXQI7yIKluT3+BJOkFY0eX2Zuo7fpSf4Tf1iI5DmS/saoy+JAHIJbF/bDCmMmLS443RvECE8Z8=;20:t3aAIPKTBDUqs65EKr05ue2tIfsSwpY9uQJScy+AZn+A0ceq+32zJbWYFSFcf49Y47YeLux46YLxPDbi9U8ucA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2015 06:48:24.5260 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB361 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/3/2015 11:55 PM, Martin Kletzander wrote: > Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug) don't want to spend time on fixing such drivers, right? Or. > > Signed-off-by: Martin Kletzander > --- > There is one warning reported in this patch though. That's because of > the multiline string and it's pre-existing. Feel free to let me know > if that should be fixed too, I'd also remove the pointless '#' then. > On the other hand, it'll create more-than-80-columns long line. > > drivers/staging/rdma/ipath/ipath_driver.c | 19 ++++++++----------- > drivers/staging/rdma/ipath/ipath_file_ops.c | 12 ++++++------ > drivers/staging/rdma/ipath/ipath_iba6110.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++----- > drivers/staging/rdma/ipath/ipath_intr.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_sysfs.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_verbs.c | 4 ++-- > 7 files changed, 30 insertions(+), 36 deletions(-)