From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbbJEJBh (ORCPT ); Mon, 5 Oct 2015 05:01:37 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60798 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbbJEJBg (ORCPT ); Mon, 5 Oct 2015 05:01:36 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79d66d000001509-57-56123c6d879d Content-transfer-encoding: 8BIT Message-id: <56123C6C.2020108@samsung.com> Date: Mon, 05 Oct 2015 18:01:32 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: k.kozlowski@samsung.com, ramakrishna.pallala@intel.com, gregkh@linuxfoundation.org, ckeepax@opensource.wolfsonmicro.com, rf@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, myungjoo.ham@samsung.com Subject: Re: [PATCH] extcon: Modify the id and name of external connector References: <1443930336-25422-1-git-send-email-cw00.choi@samsung.com> <56123427.2030702@ti.com> In-reply-to: <56123427.2030702@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsWyRsSkWDfPRijM4M5FZot/U26wWzw7qm3R vHg9m8XrF4YWl3fNYbO43biCzWL52/9sFgvf3GSymDXxD4tFzyMtBy6PnbPusnss3vOSyWP/ 3DXsHi8n/mbz6NuyitHj+I3tTB6fN8kFsEdx2aSk5mSWpRbp2yVwZTT962IvmKJf8a7tMHsD 43PVLkZODgkBE4l7XcdZIGwxiQv31rN1MXJxCAmsYJRY/7SVFaZozeOlUIlZjBKXThxhBEnw CghK/Jh8D6ibg4NZQF7iyKVskDCzgLrEpHmLmCHqHzBKtO14xAxRryWx/fk5sG0sAqoSKy+3 gcXZgOL7X9xgA5kjKhAh0X2iEiQsIpAiMXH1SxaQOcwgc55P3At2kLCAp8SkA7/YQGwhgUSJ ngsXweZwCqhJvG7/ANYgIfCTXeLtg/esEMsEJL5NPgR2qISArMSmA8wQj0lKHFxxg2UCo9gs JO/MQnhnFpJ3FjAyr2IUTS1ILihOSi8y1StOzC0uzUvXS87P3cQIjNDT/55N3MF4/4D1IUYB DkYlHl6JJMEwIdbEsuLK3EOMpkBHTGSWEk3OB6aBvJJ4Q2MzIwtTE1NjI3NLMyVxXh3pn8FC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGGW3LE1YMfuhxQrFux+M/h5/kXVEVbp9IYvVUzbm wD9Lnm9imerifScph71b5IHPi95TDN9nFMVavejazhU3pzxLwdFv4VsjnVuP1C67t2yI/PXq aGYcM9Pp7bnSDK5xjz9e6Ul6d0a/u/kW//Xm5f8Xa989e8p/Ve3iR0nW/o/2JKe/tWP976vE UpyRaKjFXFScCABg06ilywIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42I5/e+xoG6ujVCYwe6/lhb/ptxgt3h2VNui efF6NovXLwwtLu+aw2Zxu3EFm8Xyt//ZLBa+uclkMWviHxaLnkdaDlweO2fdZfdYvOclk8f+ uWvYPV5O/M3m0bdlFaPH8RvbmTw+b5ILYI9qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUz MNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpOSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBc j5EBGkhYw5jR9K+LvWCKfsW7tsPsDYzPVbsYOTkkBEwk1jxeygZhi0lcuLceyObiEBKYxShx 6cQRRpAEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0yat4gZov4Bo0TbjkfMEPVaEtufn2MB sVkEVCVWXm4Di7MBxfe/uMEGMkdUIEKi+0QlSFhEIEVi4uqXLCBzmEHmPJ+4lxUkISzgKTHp wC+w44QEEiV6LlwEm8MpoCbxuv0DywRGoCsRzpuFcN4sJOctYGRexSiRWpBcUJyUnmuYl1qu V5yYW1yal66XnJ+7iRGcBJ5J7WA8uMv9EKMAB6MSD++BeMEwIdbEsuLK3EOMEhzMSiK8r8yE woR4UxIrq1KL8uOLSnNSiw8xmgL9N5FZSjQ5H5ig8kriDY1NzIwsjcwNLYyMzZXEeW8cYggT EkhPLEnNTk0tSC2C6WPi4JRqYLSY/LLHuaDrrW0pUzSP2OKbJ6b47bY+PrNZaMVd0dzs89fO Tktw9r9qYcKXKsJ82WdJxLNVzNqrA9nLF0cHRa1eyNS26bD2xydpJ1bwlUp892BiNDn0VCHh VMLXW0qcnlWNM+9aV/Cp/vj7+PkB7hleCvmtdrN7b+0Uld/I/0N8Y/HTDz+X6yuxFGckGmox FxUnAgB+kkdMGAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On 2015년 10월 05일 17:26, Roger Quadros wrote: > Chanwoo, > > On 04/10/15 06:45, Chanwoo Choi wrote: >> This patch modifies the id and name of external connector with the additional >> prefix to clarify both attribute and meaning of external connector as following: >> - EXTCON_CHG_* mean the charger connector. >> - EXTCON_JACK_* mean the jack connector. >> - EXTCON_DISP_* mean the display port connector. >> >> Following table show the new name of external connector with old name: >> ------------------------------------------------- >> Old extcon name | New extcon name | >> ------------------------------------------------- >> EXTCON_TA | EXTCON_CHG_USB_DCP | >> EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST | >> EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW | >> EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP | >> ------------------------------------------------- >> EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE| >> EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE | >> EXTCON_LINE_IN | EXTCON_JACK_LINE_IN | >> EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT | >> EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN | >> EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT | >> EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN | >> EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT | >> ------------------------------------------------- >> EXTCON_HMDI | EXTCON_DISP_HDMI | >> EXTCON_MHL | EXTCON_DISP_MHL | >> EXTCON_DVI | EXTCON_DISP_DVI | >> EXTCON_VGA | EXTCON_DISP_VGA | >> ------------------------------------------------- >> >> And, when altering the name of USB charger connector, EXTCON refers to the >> "USB battery charging specification"[1] to use the standard name of USB >> charging port as following. Following name of USB charging port are already used >> in power_supply subsystem. We chan check it on patch[2]. >> - EXTCON_CHG_USB /* Standard Downstream Port */ >> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >> - EXTCON_CHG_USB_ACA /* Accessory Charging Adapter */ >> >> [1] http://www.usb.org/developers/docs/devclass_docs/USB_Battery_Charging_1.2.pdf >> [2] commit 85efc8a18ce ("[PATCH] power_supply: Add types for USB chargers") >> >> Signed-off-by: Chanwoo Choi >> --- >> drivers/extcon/extcon-arizona.c | 18 ++++++------ >> drivers/extcon/extcon-axp288.c | 12 ++++---- >> drivers/extcon/extcon-max14577.c | 18 ++++++------ >> drivers/extcon/extcon-max77693.c | 32 +++++++++++---------- >> drivers/extcon/extcon-max77843.c | 27 ++++++++++-------- >> drivers/extcon/extcon-max8997.c | 21 +++++++------- >> drivers/extcon/extcon-rt8973a.c | 4 +-- >> drivers/extcon/extcon-sm5502.c | 4 +-- >> drivers/extcon/extcon.c | 60 ++++++++++++++++++++------------------- >> include/linux/extcon.h | 61 +++++++++++++++++++++++----------------- >> 10 files changed, 138 insertions(+), 119 deletions(-) >> > > > >> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c >> index 8dd0af1..505a028 100644 >> --- a/drivers/extcon/extcon.c >> +++ b/drivers/extcon/extcon.c >> @@ -39,37 +39,39 @@ >> #define CABLE_NAME_MAX 30 >> >> static const char *extcon_name[] = { >> - [EXTCON_NONE] = "NONE", >> + [EXTCON_NONE] = "EXTCON_NONE", >> >> /* USB external connector */ >> - [EXTCON_USB] = "USB", >> - [EXTCON_USB_HOST] = "USB-HOST", >> - >> - /* Charger external connector */ >> - [EXTCON_TA] = "TA", >> - [EXTCON_FAST_CHARGER] = "FAST-CHARGER", >> - [EXTCON_SLOW_CHARGER] = "SLOW-CHARGER", >> - [EXTCON_CHARGE_DOWNSTREAM] = "CHARGE-DOWNSTREAM", >> - >> - /* Audio/Video external connector */ >> - [EXTCON_LINE_IN] = "LINE-IN", >> - [EXTCON_LINE_OUT] = "LINE-OUT", >> - [EXTCON_MICROPHONE] = "MICROPHONE", >> - [EXTCON_HEADPHONE] = "HEADPHONE", >> - >> - [EXTCON_HDMI] = "HDMI", >> - [EXTCON_MHL] = "MHL", >> - [EXTCON_DVI] = "DVI", >> - [EXTCON_VGA] = "VGA", >> - [EXTCON_SPDIF_IN] = "SPDIF-IN", >> - [EXTCON_SPDIF_OUT] = "SPDIF-OUT", >> - [EXTCON_VIDEO_IN] = "VIDEO-IN", >> - [EXTCON_VIDEO_OUT] = "VIDEO-OUT", >> - >> - /* Etc external connector */ >> - [EXTCON_DOCK] = "DOCK", >> - [EXTCON_JIG] = "JIG", >> - [EXTCON_MECHANICAL] = "MECHANICAL", >> + [EXTCON_USB] = "EXTCON_USB", >> + [EXTCON_USB_HOST] = "EXTCON_USB_HOST", >> + >> + /* Charging external connector */ >> + [EXTCON_CHG_USB] = "EXTCON_CHG_USB", >> + [EXTCON_CHG_USB_FAST] = "EXTCON_CHG_USB_FAST", >> + [EXTCON_CHG_USB_SLOW] = "EXTCON_CHG_USB_SLOW", > > How does FAST & SLOW correlate to USB specifications? There is no specification about FAST & SLOW USB charger. Just, the datasheet of MUIC (Micro-USB Interface Circuit) device can detect the DCP (Dedicated Charging Port) and more two type charger according to current value as following: For example, max77693 MUIC device (is used on Samsung Galaxy S3) - CHG_USB_DCP: current up to 1.5A - CHG_USB_SLOW : current up to 500mA - CHG_USB_FAST : current up to 1A or 2A max77836 MUIC device (is used on Samsung gear 2) - CHG_USB_DCP: current up to 1.5A - CHG_USB_SLOW : current up to 500mA - CHG_USB_FAST : current up to 1A or 2A max77843 MUIC device (is used on Samsung Galaxy Note4) - CHG_USB_DCP: current up to 1.5A - CHG_USB_SLOW : current up to 500mA - CHG_USB_FAST : current up to 1A or 2A If MUIC device detects the some USB charger which has the more maximum current than DCP, this muic device call the FAST charger. Also, there is oppsite case for SLOW charger. > >> + [EXTCON_CHG_USB_DCP] = "EXTCON_CHG_USB_DCP", >> + [EXTCON_CHG_USB_CDP] = "EXTCON_CHG_USB_CDP", > > What about USB ACA? ACA is "Accessory Charging Adapter". But, I didn't understand the role of ACA charger type. I'll drop ACA type on next version. [snip] Thanks, Chanwoo Choi