From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingi Kim <ingi2.kim@samsung.com>
Subject: Re: [PATCH 1/2] leds: rt5033: add DT binding for RT5033
Date: Mon, 05 Oct 2015 19:40:04 +0900
Message-ID: <56125384.5030603@samsung.com>
References: <1443778875-18261-1-git-send-email-ingi2.kim@samsung.com>
 <1443778875-18261-2-git-send-email-ingi2.kim@samsung.com>
 <CAL_JsqL13SC132eGRrUmrH4LTD61ZtNshFibSWLC8OEP+4zoQA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-reply-to: <CAL_JsqL13SC132eGRrUmrH4LTD61ZtNshFibSWLC8OEP+4zoQA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Herring <robh@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Richard Purdie <rpurdie@rpsys.net>, Jacek Anaszewski <j.anaszewski@samsung.com>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux LED Subsystem <linux-leds@vger.kernel.org>
List-Id: linux-leds@vger.kernel.org

Hello, Rob Herring

I'll push ver2 patch soon with your acked
because other patch has some issues.

Thanks for the review.

On 2015=EB=85=84 10=EC=9B=94 02=EC=9D=BC 23:31, Rob Herring wrote:
> On Fri, Oct 2, 2015 at 4:41 AM, Ingi Kim <ingi2.kim@samsung.com> wrot=
e:
>> This patch adds the device tree bindings for RT5033 flash LEDs.
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
>=20
> Acked-by: Rob Herring <robh@kernel.org>
>=20
>> ---
>>  .../devicetree/bindings/leds/leds-rt5033.txt       | 38 +++++++++++=
+++++++++++
>>  1 file changed, 38 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-rt50=
33.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt =
b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> new file mode 100644
>> index 0000000..2ef7bdc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> @@ -0,0 +1,38 @@
>> +* Richtek Technology Corporation - RT5033 Flash LED Driver
>> +
>> +The RT5033 Flash LED Circuit is designed for one or two LEDs drivin=
g
>> +for torch and strobe applications, it provides an I2C software comm=
and
>> +to trigger the torch and strobe operation.
>> +
>> +Required properties:
>> +- compatible : Must be "richtek,rt5033-led".
>> +
>> +A discrete LED element connected to the device must be represented =
by a child
>> +node - see Documentation/devicetree/bindings/leds/common.txt.
>> +
>> +Required properties of the LED child node:
>> +  See Documentation/devicetree/bindings/leds/common.txt
>> +- led-max-microamp : Minimum Threshold for Timer protection
>> +  is defined internally (Maximum 200mA).
>> +- flash-max-microamp : Flash LED maximum current
>> +- flash-max-timeout-us : Flash LED maximum timeout
>> +
>> +Optional properties of the LED child node:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +rt5033 {
>> +       compatible =3D "richtek,rt5033";
>> +
>> +       led {
>> +               compatible =3D "richtek,rt5033-led";
>> +
>> +               flash-led {
>> +                       label =3D "rt5033-flash";
>> +                       led-max-microamp =3D <200000>;
>> +                       flash-max-microamp =3D <800000>;
>> +                       flash-max-timeout-us =3D <1216000>;
>> +               };
>> +       };
>> +}
>> --
>> 2.0.5
>>
>=20