From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 2/9] xen/arm: io: Extend write/read handler to pass the register in parameter Date: Mon, 5 Oct 2015 13:58:04 +0100 Message-ID: <561273DC.6080500@citrix.com> References: <1444049512-15323-1-git-send-email-julien.grall@citrix.com> <1444049512-15323-3-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zj5Mr-0002Lz-S7 for xen-devel@lists.xenproject.org; Mon, 05 Oct 2015 12:59:49 +0000 In-Reply-To: <1444049512-15323-3-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 05/10/15 13:51, Julien Grall wrote: > Rather than letting each handler to retrieve the register used by the > I/O access, add a new parameter to pass the register in parameter. > > This will help to implement generic register manipulation on I/O access > such as sign-extension and endianess. > > Read handlers need to modify the value of the register, so a pointer to > it is given in argument. Write handlers shouldn't modify the register, > therefore only a plain value is given. > > Signed-off-by: Julien Grall > Acked-by: Ian Campbell > > --- > > Ian, I haven't kept my Acked-by because of code clash while rebasing > on top of "xen/arm: io: Extend write/read handler to pass private data" > [1]. Hmmm, this doesn't match what I did (i.e keeping the acked-by from Ian). The conflict with "xen/arm: io: Extend write/read handler to pass private data" should not be controversial. Let me know if you disagree. Regards, -- Julien Grall