[meta-fsl-arm][PATCH] image_types_fsl.bbclass: make mkfs.vfat use FAT32 in all cases

[meta-fsl-arm][PATCH] image_types_fsl.bbclass: make mkfs.vfat use FAT32 in all cases

[Schrempf Frieder]

as otherwise FAT16 might be used, which seems quite outdated and can cause issues in certain environments
(e.g. older versions of U-Boot)

Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>
---
 classes/image_types_fsl.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index d6c6421..8fc3bd2 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -152,7 +152,8 @@ generate_imx_sdcard () {
 	# Create boot partition image
 	BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
 	                  | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 1024 }')
-	mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
+
+	mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -F 32 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
 	mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
 
 	# Copy boot scripts
@@ -255,7 +256,7 @@ generate_mxs_sdcard () {
 		BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
 	        | awk '/ 2 / { print substr($4, 1, length($4 -1)) / 1024 }')
 
-		mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
+		mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -F 32 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
 		mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
 		if test -n "${KERNEL_DEVICETREE}"; then
 			for DTS_FILE in ${KERNEL_DEVICETREE}; do
-- 
1.9.1

Re: [meta-fsl-arm][PATCH] image_types_fsl.bbclass: make mkfs.vfat use FAT32 in all cases

[Otavio Salvador]

Hello Schrempf,

First I would like to thank you for sending the patch...

On Thu, Oct 1, 2015 at 9:40 AM, Schrempf Frieder
<frieder.schrempf@exceet.de> wrote:
> as otherwise FAT16 might be used, which seems quite outdated and can cause issues in certain environments
> (e.g. older versions of U-Boot)
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>

I applied it in master branch but it seems you based it on Fido as I
had to fix a Conflict, when applying. Please next time rebase and test
the patches on top of master before sending it :)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH] image_types_fsl.bbclass: make mkfs.vfat use FAT32 in all cases

[Schrempf Frieder]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

Thanks Otavio!
This was my first patch and I will take care of rebasing on master next time.
BTW: My first name is Frieder (somehow the mailserver of my company always sends the names reversed)

On 05.10.2015 14:37, Otavio Salvador wrote:

Hello Schrempf,

First I would like to thank you for sending the patch...

On Thu, Oct 1, 2015 at 9:40 AM, Schrempf Frieder
<frieder.schrempf@exceet.de><mailto:frieder.schrempf@exceet.de> wrote:


as otherwise FAT16 might be used, which seems quite outdated and can cause issues in certain environments
(e.g. older versions of U-Boot)

Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de><mailto:frieder.schrempf@exceet.de>


I applied it in master branch but it seems you based it on Fido as I
had to fix a Conflict, when applying. Please next time rebase and test
the patches on top of master before sending it :)



[-- Attachment #2: Type: text/html, Size: 1459 bytes --]

Re: [meta-fsl-arm][PATCH] image_types_fsl.bbclass: make mkfs.vfat use FAT32 in all cases

[Otavio Salvador]

On Mon, Oct 5, 2015 at 10:35 AM, Schrempf Frieder
<frieder.schrempf@exceet.de> wrote:
> Thanks Otavio!

You're welcome!

> This was my first patch and I will take care of rebasing on master next
> time.

Great! This is fine, I just wanted to notify you so you can get used
to the process.

I am looking forward for your next patches ;-)

> BTW: My first name is Frieder (somehow the mailserver of my company always
> sends the names reversed)

I see! Thanks Frieder! :-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750