From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file Date: Mon, 5 Oct 2015 07:05:12 -0700 Message-ID: <56128398.8070908@sandisk.com> References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bn1on0071.outbound.protection.outlook.com ([157.56.110.71]:45920 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751910AbbJEOFU (ORCPT ); Mon, 5 Oct 2015 10:05:20 -0400 In-Reply-To: <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Rasmus Villemoes , Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org On 10/05/15 02:26, Rasmus Villemoes wrote: > - {0x041A, "Logical unit not ready, start stop unit command in " > - "progress"}, > - {0x041B, "Logical unit not ready, sanitize in progress"}, > - {0x041C, "Logical unit not ready, additional power use not yet " > - "granted"}, Please convert these multi-line strings into single line string constants such that users can look up these easily with grep. > + > +SENSE_CODE(0, NULL) The above looks confusing to me. Please leave this out and add { 0, NULL } at the end of the additional[] array instead. Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbbJEOF1 (ORCPT ); Mon, 5 Oct 2015 10:05:27 -0400 Received: from mail-bn1on0071.outbound.protection.outlook.com ([157.56.110.71]:45920 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751910AbbJEOFU (ORCPT ); Mon, 5 Oct 2015 10:05:20 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-27-5612839972a8 Subject: Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file To: Rasmus Villemoes , Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> CC: , From: Bart Van Assche Message-ID: <56128398.8070908@sandisk.com> Date: Mon, 5 Oct 2015 07:05:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42JZI8azSHdms1CYwfGlihZ7Fk1isjg9YRGT xf/1t1ksLu+aw2bRfX0Hm8XjWfPYHNg8Nq/Q8jj84wezx4WubI/Np6s9Pm+SC2CN4rJJSc3J LEst0rdL4Mq4+O8aW8ElloqnE88xNjCeZ+5i5OSQEDCR2Dd/MpQtJnHh3nq2LkYuDiGBE4wS 0y8fYYZwtjNKvL4+gQmm4+W1zawQic2MEue2LARyODiEBbwlGidKg8RFBFYwShzeewNq1AZG ibffNoHtYBZwkLh0+jsriM0mYCTx7f1MFhCbV0BLYt2KHiaQQSwCKhJbtiaDhEUFIiROnX3L BlEiKHFy5hOwck4BT4mz/1+zg5QzC9hLPNhaBjFdXmL72zlgR0sInGWV+DThLthaIQF1iZNL 5jNNYBSZhWTULIT2WUjaFzAyr2IUy83MKc5NTy0wNNIrTsxLySzO1kvOz93ECI4crswdjCsm mR9iFOBgVOLhPRAvGCbEmlhWXJl7iFGCg1lJhNfSVShMiDclsbIqtSg/vqg0J7X4EKM0B4uS OG9vrk6okEB6YklqdmpqQWoRTJaJg1OqgVFN0DXSXeB+5uZzLgIHMicGNioqd5xwt+2x57uk 65opZ9JlLL+Zb687Z5PM67ytn1/naW3b/PhAKN83Pme+DzMFRO5cPu2aIiscufR47+25Uyf8 T+X0zGPa4aCXflGzY8eNyicvXR3La4JPr7/LNk0r3yJdq/bAvyXqi2v2qq2L1umxMWSOVWIp zkg01GIuKk4EADyd7YaYAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDJMWRmVeSWpSXmKPExsXCtZEjRXdms1CYQfszcYs9iyYxWZyesIjJ 4v/62ywWl3fNYbPovr6DzeLxrHlsDmwem1doeRz+8YPZ40JXtsfm09UenzfJBbBGcdmkpOZk lqUW6dslcGVc/HeNreASS8XTiecYGxjPM3cxcnJICJhIvLy2mRXCFpO4cG89WxcjF4eQwEZG iQX/VjF2MXJwCAt4SzROlAaJiwisYJToPXcJqmgDo8Tbb5vAJjEL2EhcPPiMEcRmEzCS+PZ+ JguIzSugJbFuRQ8TyCAWARWJLVuTQcKiAhESp86+ZYMoEZQ4OfMJWDmngKfE2f+v2SFG2krc mbsbary8xPa3c5gnMPLPQtIyC0nZLCRlCxiZVzGK5WbmFOemZxYYGuoVJ+alZBZn6yXn525i BIcvZ+QOxqcTzQ8xMnFwSjUwbn8yx+Tl9MXfZ29e9mPrpIyi/1X2a0pfpF3asVQ3vX/Bz4Z5 l2JEi/qfLPEXfRFi9XxJIOfZhb8PvfMsvvUi60n+BZsluQuezP0Ze9bkRQLnkblHmqck+VmL XXwf1Cof1LN/2fkU1W+rXr4PWhrMMPXqZy6jxv+15f9qdU1m3fzjG2DadmWyzB0lluKMREMt 5qLiRACF0Lh1DwIAAA== X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD019;1:+9PuU0KU5+5zhcQa6b6lxarfdJzE3oUBRJnFg8sEHcSCOFBHAR5H5yoIBo7KSktP/QJioDL9q+Zg6p33x2yaWDMZGVJ9oUYY7in7B1sPss0gnJerV4apdDAqnMtnIuoDHEp5LEh6aFIRBmbgHsp0Fx5UVI2oow4930QlYwrxa9afo63z5tNdrCEcbf/GKpxi0Ou8D88n4E/iJP1tJhTW90j8KIIExBH0ofyVGPubEfFfyMwgC9qyKKatH1dUet8iGhX7McbdZikfwcSJ67tGfJQ7m0Vd/91f0slh/ujLMxqHUkwHWf0JT6tJ+oT4pdxqwsQ86fpY1TeXIvDv3crOKaDh5WDQy9cWZ0dlRAcdvM3gY8XzCmf6mUS2vKY2qiF6 X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(164054003)(24454002)(199003)(189002)(479174004)(23746002)(5001830100001)(5001960100002)(117636001)(86362001)(106466001)(87936001)(2950100001)(92566002)(77156002)(62966003)(83506001)(77096005)(68736005)(5008740100001)(69596002)(46102003)(189998001)(5001860100001)(81156007)(47776003)(50466002)(5001770100001)(4001350100001)(5001920100001)(4001540100001)(5007970100001)(65806001)(65956001)(36756003)(97736004)(99136001)(64706001)(59896002)(54356999)(76176999)(87266999)(65816999)(11100500001)(50986999)(64126003)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR02MB1256;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1256;2:9sHBhAA85FkW7/hA69o8bF+Oti50uTJmm9c6t1PC0zKFsfb/qyvQYmkvrKGHyzA4P5+/fFXwjqI883hTb56qiKF0otwHg0YQBHiqgDhwbXh+5I5pF/kkfLzkmg8daZWlGPHYfVi5txrfMD6hWOPtBXBBw87vu/ba6NGyaEzNR9g=;3:dB8MNQOJwlGRKh88uihJ3K5eej36Mraoa1FiAx0skoiG4oIY1goQruHF/Oy1fPoMDqLkwDqlsyCYZVV0k1LL/VJ1hQ+ZMgNR7xN06GiXV4AHj7jASU1eQtJ5SD3t+DgNnlFem5eeOvyKhiGpos1hzEuiSzBvTBWNYxnPnahhcUlw/7PeyChGZniIJXFXU+CMGlpvEi58Mt5iA7yABjW9+C6ZZek0TsaejJE3ftABH+pf8prbqm7MlhoFC7w7EcfOmo+BoczS9NcQ/MoQOJaqFA==;25:OAawghZbsg4EyPSVM3CZO6k2g7VMPbmptmxyojYjaetVoX6lqSjRIp2JUnKomyfXxIE0kJc3INpaJ1K0+U2ktPGW7ZCArYESeZm0r1b5zN+X0uaHMM0A7G5s5Ha4icdJPoyJL9nebsbFZkIlr3R3hZKMp+8YjlIxoQ6sPr1iZbj3GF0I0nt0mII4MhPcXKOdGxlDV4PQhQXJi5mrk3gPnAd5ZAjWPUzRavnq0+7Z3stFrkzm1JyeAOGtEyTgniomfSQtC2Q2Ui451JQfVA0slA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN3PR02MB1256; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1256;20:ZEkku/TTD+Sq6PjE+V9KWKiy25FPi/bmtemBPGT+JzlqkSG7cWN3spmNbTMNG6es3JJIbEmlv1tb0rxr1RjRJ9a4fc6Mdv8gcnTVpte+hn9HKTQvjO9p+PaavcDkKlciV6two5jm2a2dGYlDDRJmvrSXs0Xt3B3VmoJr8rPIZ3d9+ixPTqIPIrTnAbnParHx2W8dGHJkFq8Fd97au9AyPlq88KFo8qInWyyloaHi/XBeg/wKjEwSNCsvDCDQIjLOzXhMMieQoncbFZg+qNI65k0PKdzNjBoNqKEn92BnE6FkIasjvb6Lmr5BH4gSvqBysQsJ9Mw8Y3olJCfZyvrcI7oY17YoaRUnviq3uAObpKMXow86xOSjz7zwnfhcQm4cz8XfPl65PTVotZ0o2Oolf6cOQoFZ+KKSd+8uSU/gten0F70uD2sCZCZStnTgb81b05cfc1HeqLQQwJijo1pJOYeCFauR1iP1fvzywhi9gyl4ltTB64t3jRzHJJe5ZJN7;4:iW5gbA3mOP69cpjd4aI/eh3XIpmcKAja3wJVT5dJ019Hf6H7p2BivQaAedzvuKLtEWYdev704CeuUzmt1NErJn0iHo5t0riuh3CwbI6tS3KcgTpwqk67ReWV3HK2LeC8ec8JM1WH4BpdHBSDvj6Ewb5MGlqwC0ngq394uevr8C7e75hm6EDSgV3Qh4FRsMoe38WR/wMPdIlAwvGFqbhDLMTpNpLBWP454jVSV7aKienfrGbr/bb977cLj/Rni+DnZ901RnxNwK7UT+yToaDOYUs70vsKD2xIEu9K14eIc3xgta84YC0inPCXCQrZSUOGbXMfo7YhVvjfZQw1RksVLPzgnXuxjJ8NVOsVetzCnJI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BN3PR02MB1256;BCL:0;PCL:0;RULEID:;SRVR:BN3PR02MB1256; X-Forefront-PRVS: 07200C0526 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR02MB1256;23:kGEnlQpjmf0B4bjZAycacAGVBOgNIgH537xiK?= =?Windows-1252?Q?4HszlzMzQGSNql3qcKT1MZlrRLfgY8dGhoNXCgQtSfZpS+apAIQ6qM12?= =?Windows-1252?Q?DX8GTUqp1eyB9VCXuRfXYcNOazZ1mg1xjUpAcpLPdnaXlDZI//kIbok0?= =?Windows-1252?Q?Qrj+qpSJtzQvLKfatfqNP4FGsBIFFWwXaNgtc+cS6nez901UxliG9QxL?= =?Windows-1252?Q?Kfo2Nf1vi+jfzEreigbhsPP+xrBsZiwKUURfwo1Y9hZT04RNggdOxhez?= =?Windows-1252?Q?vA8n9Xyxl2k3qcnqd4YZZDWNs2rFKSPuADCp+EeEO9snz5Dmam8XZWwC?= =?Windows-1252?Q?9IFOfrdXi62Q4C4FKQL1nFPNnTnl4EJj9DvkZECjViDyQeq0C7FyhusW?= =?Windows-1252?Q?p8wgoKlCdZWFsOomk3uSz5ZKJE4+Yp6nGTxSDcq1x8tZ7aPUS0Z1raPw?= =?Windows-1252?Q?Aza2WcWJFGeMn5HjH0rb6EmSqc08nFC6tSGrfufIfl99LuVSEJJe4AOY?= =?Windows-1252?Q?3Sqjxi3c8627+Tvt1RLXJBHbRTz3Lw29tfWCoGol7Anf5CH6VpuHSuEZ?= =?Windows-1252?Q?tZ//8E9BWOO3t7JtyWmG6oCPx4dHkEDVw1CH7D4+ZMkzKTBq2n/ebCKC?= =?Windows-1252?Q?ITp6zo6d19xLGTqTb+RDcHhmJF7OkdqW+7rUEmKyx83zewcUROh4HnbV?= =?Windows-1252?Q?S+0X5Vj5DR81peITjcFWjiQXaR8+fm620kq1l/i6hurZwwgB0eEHy1mn?= =?Windows-1252?Q?ImTtODXpxFwngYQvRvkJNcxFktbXU63ys5C7yEGnlbRNgJrkZly5CE/y?= =?Windows-1252?Q?U5Tw8WXESNZSpwvQPAEEQ1aM91Bt1UE3D8lGMQEMA4bDas9oQ8liZS3c?= =?Windows-1252?Q?JFEv9pJXhk+pfIjJ/+1vcZnYxRaHYxBclA8Xup7LPc16/p75iJrXk/o4?= =?Windows-1252?Q?RSnAW6x627qJp58moJC8lPPpWOegpiT1MI27sqiCqYdQ5HqXL1HYwyTz?= =?Windows-1252?Q?VpEFIvUrW0xge0WEZHEHgAC/YvX0U855G/6GguvDi30JANV99Th1ac6T?= =?Windows-1252?Q?GlTYPuYoYJ0qGJMqKX2rUWy++TtUC3t204eEHGpTQGLrMkgLNRxgW+E3?= =?Windows-1252?Q?iCO+lZkC5Vxul6MLCjbJY6HIME6lrec3OZQG4LNBCOb/xEaZKv/A7uhx?= =?Windows-1252?Q?jaOdK/GIVVFeTlSaVbQWY5Wq3M1+Ka7q0SU0Nim93/eJ7t20NFw1DQ3e?= =?Windows-1252?Q?TOpyNUj9MzAncz8tW5RewwSQ8eKTFWBEpRnMIAVZcnQ70U5k5gfu2pZv?= =?Windows-1252?Q?pOMpAynh0QQiHFHko4D9UzHWxKM9/8k26Jp3qjKz8r4YZNBSwPw2e0AV?= =?Windows-1252?Q?ryE2W9g9llXRA/cWsrKATmQ7vWkQde9hBYBhnhiUv/3EUNUC0NmYIkoy?= =?Windows-1252?Q?rtLKHxetpH/DePHjfM9?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1256;5:K+ya9xd6AltCnS5K8HIsU5OnrdyZKVJBYdKRknYnbxg42YZr4QU4jjw5bCB0B1393E0UKwB9nGW7HcVi2EFbO1nBzFueeAxA+s+MW0v04UI38CLm8dXD8Kc3vQJiJ5qEgAH9T81beynkmvTSAH8WZw==;24:dAGZaEyts5uHf3l1Jqww59JAX1B8tit7gmpwLJI1SE1eOCK5kul2eE82EOf0+/pEJPAzody8NztGgYbHPWmrQ8ClsMd1eMHyzLl+RX9YGaI=;20:x6N5uYH8LTIyIV0EVx6jl5eTSbOXPaVdzfI+w1Wqx0nIXW8fwzOoGJzTxmQoOTk0TTI4B/y3/Z5Ca4rTvqkkzbBGyOP7roy3lHfF5dxPS8L/ErWQYH9RmO1nPB8/rWOJEl0E6lzmqcFRhGTkFlQYCBAV7QBDhMTtJoeVD/5xqGu7uj9PuAi7+72ywKIrR121bx/j+JqZjeHHsDCX77wvqzu52jENx9EvB1edRO+yn7axG3c9zjxXNK1cZCn66TIe SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2015 14:05:13.6927 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR02MB1256 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/15 02:26, Rasmus Villemoes wrote: > - {0x041A, "Logical unit not ready, start stop unit command in " > - "progress"}, > - {0x041B, "Logical unit not ready, sanitize in progress"}, > - {0x041C, "Logical unit not ready, additional power use not yet " > - "granted"}, Please convert these multi-line strings into single line string constants such that users can look up these easily with grep. > + > +SENSE_CODE(0, NULL) The above looks confusing to me. Please leave this out and add { 0, NULL } at the end of the additional[] array instead. Thanks, Bart.