From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Date: Mon, 5 Oct 2015 07:11:51 -0700 Message-ID: <56128527.1000703@sandisk.com> References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org To: Rasmus Villemoes , Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 10/05/15 02:26, Rasmus Villemoes wrote: > struct error_info { > unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ > - const char * text; > + unsigned short size; > }; Had you considered to use the type uint16_t instead of unsigned short ? Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbbJEOMG (ORCPT ); Mon, 5 Oct 2015 10:12:06 -0400 Received: from mail-by2on0054.outbound.protection.outlook.com ([207.46.100.54]:1150 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752182AbbJEOL7 (ORCPT ); Mon, 5 Oct 2015 10:11:59 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-8d-56128528a547 Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k To: Rasmus Villemoes , Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk> CC: , From: Bart Van Assche Message-ID: <56128527.1000703@sandisk.com> Date: Mon, 5 Oct 2015 07:11:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42JZI8azSFejVSjMoHERn8WeRZOYLE5PWMRk 8X/9bRaLy7vmsFl0X9/BZvF41jw2BzaPzSu0PA7/+MHscaEr22Pz6WqPz5vkAlijuGxSUnMy y1KL9O0SuDKuf7zFVjCTqWJ1TzdrA+M1xi5GTg4JAROJ5ddWQdliEhfurWfrYuTiEBI4wSgx 79EUdghnO6PE1Js3gRwOsI5H+/Qh4psZJV72dLOAdAsLeElcXXedBSQhIrCCUeLw3htQozYw SrRM3scOUsUs4CBx6fR3VhCbTcBI4tv7mWDdvAJaEi9f32AGsVkEVCQu9P0Fu0lUIELi1Nm3 bBA1ghInZz4Bq+cU8JRY/2cpC8hFzAL2Eg+2lkGMl5fY/nYOM8heCYGzrBIL7i4AmyMkoC5x csl8pgmMIrOQjJqF0D4LSfsCRuZVjGK5mTnFuempBYZGesWJeSmZxdl6yfm5mxjBscOVuYNx xSTzQ4wCHIxKPLwH4gXDhFgTy4orcw8xSnAwK4nwWroKhQnxpiRWVqUW5ccXleakFh9ilOZg URLn7c3VCRUSSE8sSc1OTS1ILYLJMnFwSjUwSin/9pS5X//ftPHsuscsy2a9YD2W8Pdhe7/W ap/7CQ+lZt689bvmrQAjw1vdrP4NK48+XrmWa3mpWn9d2dakyTVdB7qtJz1NWn6g70pCyKSY hAjPX7nZgQ83uFy8Vri37+3q+e/3Bff9KFNx2vgw7kDAuvB7694+NTHW6vbcMO/uJIaEaNNL m5VYijMSDbWYi4oTAfUV0veZAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLJMWRmVeSWpSXmKPExsXCtZEjRVejVSjMoGUTk8WeRZOYLE5PWMRk 8X/9bRaLy7vmsFl0X9/BZvF41jw2BzaPzSu0PA7/+MHscaEr22Pz6WqPz5vkAlijuGxSUnMy y1KL9O0SuDKuf7zFVjCTqWJ1TzdrA+M1xi5GDg4JAROJR/v0uxg5gUwxiQv31rN1MXJxCAls ZJSY8/w1G0hCWMBL4uq66ywgCRGBFYwSvecuQVVtYJRombyPHaSKWcBG4uLBZ4wgNpuAkcS3 9zNZQGxeAS2Jl69vMIPYLAIqEhf6/oLViApESJw6+5YNokZQ4uTMJ2D1nAKeEuv/LGWBmGkr cWfubmYIW15i+9s5zBMY+WchaZmFpGwWkrIFjMyrGMVyM3OKc9MzCwwN9YoT81Iyi7P1kvNz NzGCA5gzcgfj04nmhxiZODilGhj7VGp9VO/ParCRune1zHXX5PgNR/Mn8JnudWw63/hUNsbM 5IxbmdQs9Tszb37br/Np5f7fy8Kao4Pdv582a5radsh42zS+FXum7D3RcPjL5f9/tJfMyfS/ s+Ra2lfp5S1rp1051fY8QY/v9oxdWzZsq88qMLg23TxSftqvJ/lZas4H2JUNIl7tVWIpzkg0 1GIuKk4EAJ353yIQAgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD018;1:GU9m5J3LAgRGwFqbI+BWdfyRhinldu8jj2SJT9ysY5DsetReovjLMxi17YjezlkiNHHD6RgFLMclgYBNySMjaZNwaf+QxUzBTAHlGgEM92hdRzY5bRQS6ma7MJHxZK7FLwLeAA2rJ5E7cuFf+nh6vAVTwSKlGOi1Aq333a3tWrILCeP11MjSRywbxUdfyPnMQ4z8BWqaubuaJ9daSapAaY32P3mL2zQ0s5K7UInQ/ZJ0cDaft8icWu3yC4V+heNu5hVSuuyFzk8sXz9Hkg2TMLVvn9Xp+eHmfjvOriDGFkgtiDtA4sKF0GHgDgrTBEs01mgyqSqLi7liq7eedxwi9oMrP+afgcw+PheOgGOsocj6fckOE+EaBHb3OzKK4tFV X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(479174004)(189002)(59896002)(81156007)(50986999)(4001350100001)(97736004)(5008740100001)(5001860100001)(5007970100001)(92566002)(23746002)(77096005)(5001830100001)(86362001)(77156002)(69596002)(54356999)(76176999)(5001770100001)(4001540100001)(87266999)(65806001)(68736005)(50466002)(2950100001)(36756003)(62966003)(83506001)(106466001)(47776003)(65956001)(46102003)(64706001)(64126003)(558084003)(65816999)(87936001)(189998001)(99136001)(5001960100002)(117636001)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0201MB0752;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0201MB0752;2:FUleeI/Pw/EBwl3pRK6uLN35iPifnjMaXQKV/+yxdlxsipfq7CwOc2hRc0NAS4NNvBDRfzzy7VA70kMxqn5z/IsTsf+STQPX1627D3SVV86MCNuBV+Cuz6IaowhgrYmrqzWU9XQTTsn8qiDTlo/BJwldIWwGczQvNTy9lMT+YTI=;3:u0yicVd/EftMlLraGBOW+ZJF1c+HdP6bZjwvI6q1hxsLbvnhNLcZ/meN5jP87/rt6zUcwEf1YkPZr2LdpH+UpVVZwpF8WlslNEOsErIZGitQ8/s6ya87XGLTf09Kid1s/c6Foe2TghaqFvNZzUtIInTpHoDT58fsij+M6JwJh81RYoI8GXAor3NhLAyZoK4eb7PqOi3Nga3KMxqZZmDcT6+yNWRcRsHbZH/2oQtnlusMWyyZfeXETDLyrLq8UsPnSbS31OIFF/ATHOFkqkr6MQ==;25:JD0K2QIS53ONTqeBOpZyOUMfJMe3OfMPgUdo1UEK7TGL21oznAJ9GxENwc7aupzgyvh0EAu5QmnQiTEkrXOd66giX8vzUPmmCJlQ87sEH8h2oFjRbdbOLh6Q8N9xlb5K/CFX7Cltq6sQaIup/PhqZ8362wYczS/hhPDrq0xF4X9/qFha8NC6hwEaoXcxPL6k0sffXq9kDw4LPWteoCLmf/oInpBlPxvNDU+Lg45sMImL3eEZDlLDdzjmYDp4tx79 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DM2PR0201MB0752; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0201MB0752;20:uNnM2Cjkw6a3N7d5rZyU76DJsaLG7Tvs2fLa9HIdZY3+FXIi/ZD4inejnyMNbKVFFvDi4bZzUdeDJXzjEIQwXMbt9eT/wBz05X5A8Ov6DBvy05L9PHBa+YNB5hWjpSFWx4N6vXWk0zeegDCKXmHqk9LJCFP/UIasyiEqbe0KSEDdvY15FgN7OJTd11BAnbwfRSaWoChxCZzW1zSFrAginQKYxoUXOcEXIF8uke7hBraN0X7Y+QmqnmF/xo46JyR+3z5KRT+G8BcvVNjiDsSZRu3x2wd+o0etFdW3dLfR2HBoxhl7KVsWJ7qc1GNNEgn2hBw1SGQjtSwj4YBer/CrbKTp0J16xh6BtXMQ1BwNnI/7+JK4MXd8C/KT/fzzTFRtGQQFlLCZCsS2lzNCfuM21+uVvrKaXcaFhI2WSzPAYeudo/eUXCqDFkO6iFJ9E8x/jAC+vnnQbB5B/ZCvOQvMqJByrjQDvwxmspcoeqmfWoB46z/2T3u6JzIZWAyYKQTQ;4:KQqUHhMbuSce4rQg/PvIvNzFE/RCVuLATSnLQ8J06SsECG/uOtFY+S59ZndB73sW64Df2kQP8R5QKsLQiaCZbHIaKhWYat+slT3txyaedQbT37mJm0gi6N7zLulrew6/XBbKxKApByWi0UBiJzx/h4y3TcXRQrwQrtbcosoZCQCNVxm3VGp8nlfWgN989da1Eb+/2IeZmizxb8yGzobt84Kf7dbeNmm52oVpoRz7esWfd53+bo7BmdUX2NZ7pPSBVE850orbuJ2UrMJJhr4tS7uYy5FafDv2DKGsPUoFxzrm3oh0S75AX+D1q/PHYcEMOlXDBAe+/z5TL0Oe3TsbKBaxONLRcR8Y0acdMlb5ojo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:DM2PR0201MB0752;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0752; X-Forefront-PRVS: 07200C0526 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR0201MB0752;23:0seiKEGKN52ZYQVxlKAGZypqdZnFvV7eDfH?= =?Windows-1252?Q?Cd1fFktemF5velM0xUGTI6jBQme31zxeF3oi+eiiMOWWAWxrnpJ8Fs0T?= =?Windows-1252?Q?xp6/IDWqg+XErc9IArdcVxSNyw98yr2pa52BtMTyPnqPhKBBpuYxA/mS?= =?Windows-1252?Q?TpGfP8e3VxlIe+z+LR11SmtBo2eA/xwxQbG9jQ5cqya9EYTZlckT+zYM?= =?Windows-1252?Q?XztBFIz3LDFKewuzJeC4WcLcd0dyj8fKk4itLehnEDtRA3Yo+L5PobD/?= =?Windows-1252?Q?Tj+HuD2F4h/PbWDVeEogHjSOx+5cOXsb4AnKvOxCg0l+0vCjKUDQJTyy?= =?Windows-1252?Q?UNRXgWgrQiupqZb+Pmu68I3neZF1cCI8xQrJ5Id+/0NgenQW6tXrA30S?= =?Windows-1252?Q?07oZdDT0TgrupD9vfBLmdHN8SJ/s/j/ACOXYg2vnVpOEfva9Osu4/LTY?= =?Windows-1252?Q?s35hZTAhPK0axqgla997fbAlNEvjr9O2fbDDYjs5bsYIuVClBVqL7hbJ?= =?Windows-1252?Q?lYe0lh4rbyy95pFbUD2fzSirU0HDCRLmNoqVJE5ZYEotz6xA4c8iy/Jg?= =?Windows-1252?Q?gZeGbGPF+w0MOtisdsRZa8pjL7nzzgQNtn65bwZmouXgwZnWcpeUMVXd?= =?Windows-1252?Q?kPsNtOrpVgH1Os6+lpGRYuX22/yjym5VuvHgNmQQ+gtKNa7skjkEhCHf?= =?Windows-1252?Q?s7kcVAKI63IBgpgH7vOKbXIA4U0VpsLdcfbdoqwbE0UE5EeVsZclTZaZ?= =?Windows-1252?Q?Cx9qBkFBUJnrIALhB02hnWWRDkzu/Emqs5UFV/V0ikyU7AiVR2WC+Ztq?= =?Windows-1252?Q?VbGt8BH2whPCvDfkyncpPnHKz4XmVBLobChEjh3vljFTBGe3qwkx722n?= =?Windows-1252?Q?LfENJC6j8Saihrkg07gRULyOODUVPOybdLVPgxENTFnb9Vgj26YzBdlM?= =?Windows-1252?Q?q8/Uvu2TxmjGQtkeGCBPvWwkbV6v0i4eOshgzOzSDzwzKIcr7VA9HtUG?= =?Windows-1252?Q?I6TNjpbF0fBDlN3k7S10f3RBw3/BxqVDYUTLXLk2yVzxsR1/hlCfsF55?= =?Windows-1252?Q?e781iGoGKLidXIzPDSMIhPp0Di0Fj/HU9UWelI9BYTTIMYLDo1vzQNm9?= =?Windows-1252?Q?RFFhnk+z2Ae2tN+f/pSYd4QMH419R1JFa9HQxA/FhJ2wgRpadUQzTQN6?= =?Windows-1252?Q?uZrrfeyEVN3kfB6Pyiio/sz8GLqe9sQeANQ37d1KrH/ySLn/j+J+a2FJ?= =?Windows-1252?Q?7cVUbRpApniNlb4JkWGkV9V534DhhDxEFEXHhVEkIhGysfuIK76hPCkB?= =?Windows-1252?Q?LTFOvhLtUrVT2Hy8VbXJIZ1ISbdviQtsLo42/cL+FeTrYk4zXNfMqmk+?= =?Windows-1252?Q?aTBacqc8+jF/taKdZPxNqsexzhTkIyUjBLQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0201MB0752;5:nN7lGacawa3cqrZ7epldrm+AK8GNyZHYBFJWTFoOIB8VikQ64E10eR9Knkoc/PcZ7RBvikkhjys/Yci3lQvbm8EXWPBhkMoeo+vSEz6qFyoJZ+npGbk+xlep3jOQJtBdPygd3hzCHzzMxalIFnSYPw==;24:V6OMD7lp18jH94LOhqtd/HrQRa+08InnNv6Av68YBljLIougySwkODv5gsi0sSwIwAMW6yDO6EqfwOtodXjWGuUYcH1TZWug46rx8e6Parw=;20:4lpA+2LoX5PzXuxnzcdxifAiHGGNUfD23y4CGqd124AGf6/2i0QUXNGPwqgIH1Tv2yvUICtjH02mCnYGgjpd6OQCkyeTMTIJ5BguSPMrQSBZKeMY3mbQfUyQCXDYWCNsejZ0CtJmB72Vfl7g3mGujE+P3NFafo8K5KPOrn+NYPDKdJ0TOW/HoxtIBYL8mY8wcL43ckQAszgb57C5wfRffKVQGmNKE4r540T2VJg591NfBA3cDwOQPCTUxUU6oUF3 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2015 14:11:52.4155 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0752 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/15 02:26, Rasmus Villemoes wrote: > struct error_info { > unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ > - const char * text; > + unsigned short size; > }; Had you considered to use the type uint16_t instead of unsigned short ? Bart.