All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH linux-next v3 1/1] ASoC: ad193x: add support to ad1934
Date: Mon, 05 Oct 2015 18:40:23 +0200	[thread overview]
Message-ID: <5612A7F7.3020607@metafoo.de> (raw)
In-Reply-To: <5fa6cd7e991982cea9f52d5ebba7a3aca7350ed7.1443537293.git.cyrille.pitchen@atmel.com>

Looks basically good.

On 09/29/2015 04:41 PM, Cyrille Pitchen wrote:
> The AD1934 codec has no DAC feature. Hence it register mapping is slightly

Should be "has no ADC feature". Otherwise

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

  reply	other threads:[~2015-10-05 16:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 14:41 [PATCH linux-next v3 1/1] ASoC: ad193x: add support to ad1934 Cyrille Pitchen
2015-09-29 14:41 ` Cyrille Pitchen
2015-10-05 16:40 ` Lars-Peter Clausen [this message]
2015-10-05 16:44 ` Applied "ASoC: ad193x: add support to ad1934" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5612A7F7.3020607@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cyrille.pitchen@atmel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.